Closed Bug 808419 Opened 11 years ago Closed 11 years ago

remoteautomation.py's waitForFinish() should print to the log when maxTime is reached

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17 fixed, firefox18 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla19
Tracking Flags:
Tracking Status
firefox17 --- fixed
firefox18 --- fixed

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch v1
1.26 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
...rather than just killing fennec silently.

http://hg.mozilla.org/mozilla-central/file/ab099c9e1a09/build/mobile/remoteautomation.py#l74
    74         if (status == 1 and self._devicemanager.processExist(proc.procName)):
    75             # Then we timed out, make sure Fennec is dead
    76             proc.kill()
Blocks: 778688
Attached patch Patch v1 — — Splinter Review 

        Attachment #678146 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 678146 [details] [diff] [review]
Patch v1

Review of attachment 678146 [details] [diff] [review]:
-----------------------------------------------------------------

please give this a good test on try server before pushing.

        Attachment #678146 -
        Flags: review?(jmaher) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/60c78a559a84
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

          You need to log in
          before you can comment on or make changes to this bug.