808419 - remoteautomation.py's waitForFinish() should print to the log when maxTime is reached

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Ed Morley [:emorley]]

...rather than just killing fennec silently.

http://hg.mozilla.org/mozilla-central/file/ab099c9e1a09/build/mobile/remoteautomation.py#l74
    74         if (status == 1 and self._devicemanager.processExist(proc.procName)):
    75             # Then we timed out, make sure Fennec is dead
    76             proc.kill()

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 678146 [details] [diff] [review]
Patch v1

Review of attachment 678146 [details] [diff] [review]:
-----------------------------------------------------------------

please give this a good test on try server before pushing.

Comment 3

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&rev=de234f1e54fb

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60c78a559a84

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/60c78a559a84

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/daa7e5db35c6
https://hg.mozilla.org/releases/mozilla-beta/rev/9cfebbf2973a