The default bug view has changed. See this FAQ.

remoteautomation.py's waitForFinish() should print to the log when maxTime is reached

RESOLVED FIXED in Firefox 17

Status

Testing
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Trunk
mozilla19
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

Attachments

(1 attachment)

...rather than just killing fennec silently.

http://hg.mozilla.org/mozilla-central/file/ab099c9e1a09/build/mobile/remoteautomation.py#l74
    74         if (status == 1 and self._devicemanager.processExist(proc.procName)):
    75             # Then we timed out, make sure Fennec is dead
    76             proc.kill()
Blocks: 778688
Created attachment 678146 [details] [diff] [review]
Patch v1
Attachment #678146 - Flags: review?(jmaher)
Comment on attachment 678146 [details] [diff] [review]
Patch v1

Review of attachment 678146 [details] [diff] [review]:
-----------------------------------------------------------------

please give this a good test on try server before pushing.
Attachment #678146 - Flags: review?(jmaher) → review+
https://tbpl.mozilla.org/?tree=Try&rev=de234f1e54fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/60c78a559a84
https://hg.mozilla.org/mozilla-central/rev/60c78a559a84
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
https://hg.mozilla.org/releases/mozilla-aurora/rev/daa7e5db35c6
https://hg.mozilla.org/releases/mozilla-beta/rev/9cfebbf2973a
status-firefox17: --- → fixed
status-firefox18: --- → fixed
You need to log in before you can comment on or make changes to this bug.