Closed Bug 808436 Opened 10 years ago Closed 10 years ago

[gcli] cmd refresh throws an exception

Categories

(DevTools :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: paul, Unassigned)

Details

Attachments

(1 file)

"GcliCommands is not define"

Looking at CmdCmd.jsm, I think the GcliCommands reference should be CmdCommands.
Asking Paul for review, since its only one line patch. Please change reviewer if required.

BTW, this issue was not identified as there is no test related to "cmd" command .. :|
Attachment #679199 - Flags: review?(paul)
Attachment #679199 - Flags: review?(paul) → review+
(In reply to Girish Sharma [:Optimizer] from comment #1)er if required.
> BTW, this issue was not identified as there is no test related to "cmd"
> command .. :|

Maybe you can add one? Up to you.
Optimizer: Are you planning on adding a test as per Paul's comment?
Sorry, I was unable to respond earlier due to MozCamp and vacations.

Currently, I am not sure about what kind of testing is required, or is it feasible. I suppose for the test, I first need to set the dir pref , create a dir, create some dummy files containing commands, test the commands, change the commands, do the refresh and test again and finally do cleanup ?
I see, creating tests for this command would be impractical. This fixes an important bug so marking for landing.
Whiteboard: [gcli][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/c91811dc01ba
Whiteboard: [gcli][land-in-fx-team] → [gcli][fixed-in-fx-team]
https://tbpl.mozilla.org/?rev=8a30e07815ff
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [gcli][fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.