808436 - [gcli] cmd refresh throws an exception

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Paul Rouget [:paul]]

"GcliCommands is not define"

Looking at CmdCmd.jsm, I think the GcliCommands reference should be CmdCommands.

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: GcliCommands -> CmdCommands

Asking Paul for review, since its only one line patch. Please change reviewer if required.

BTW, this issue was not identified as there is no test related to "cmd" command .. :|

Comment 2

[Paul Rouget [:paul]]

(In reply to Girish Sharma [:Optimizer] from comment #1)er if required.
> BTW, this issue was not identified as there is no test related to "cmd"
> command .. :|

Maybe you can add one? Up to you.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Optimizer: Are you planning on adding a test as per Paul's comment?

Comment 4

[Girish Sharma [:Optimizer]]

Sorry, I was unable to respond earlier due to MozCamp and vacations.

Currently, I am not sure about what kind of testing is required, or is it feasible. I suppose for the test, I first need to set the dir pref , create a dir, create some dummy files containing commands, test the commands, change the commands, do the refresh and test again and finally do cleanup ?

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I see, creating tests for this command would be impractical. This fixes an important bug so marking for landing.

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/c91811dc01ba

Comment 7

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?rev=8a30e07815ff