Closed Bug 808498 Opened 12 years ago Closed 12 years ago

Chrome debugging broke B2G debugging

Categories

(DevTools :: Debugger, defect, P2)

All
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 19

People

(Reporter: past, Assigned: past)

References

Details

(Whiteboard: [b2g])

Attachments

(1 file)

Bug 740551 apparently broke debugging on B2G. I now get the following error while connecting:

E/GeckoConsole(   77): [JavaScript Error: "aHooks.browser.contentWindow is undefined" {file: "chrome://global/content/devtools/dbg-script-actors.js" line: 35}]
Whiteboard: [b2g]
Attached patch Bustage fixSplinter Review
Apparently it wasn't a good idea to move the content window extraction code into the thread actor. The browser actors is a better place, since it can be nicely overridden by other products.
Attachment #678261 - Flags: review?(vporof)
Attachment #678261 - Flags: review?(21)
Comment on attachment 678261 [details] [diff] [review]
Bustage fix

Review of attachment 678261 [details] [diff] [review]:
-----------------------------------------------------------------

Fresh as it used to be. LGTM.
Attachment #678261 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/774f55987329
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [b2g][fixed-in-fx-team] → [b2g]
Target Milestone: --- → Firefox 19
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: