Last Comment Bug 808524 - remove unused folderTargetPopup class and binding
: remove unused folderTargetPopup class and binding
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
-- trivial (vote)
: Thunderbird 19.0
Assigned To: :aceman
Depends on: 315367
  Show dependency treegraph
Reported: 2012-11-05 03:38 PST by :aceman
Modified: 2012-11-07 09:17 PST (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (10.56 KB, patch)
2012-11-05 12:39 PST, :aceman
neil: review+
Details | Diff | Splinter Review
patch v2 (10.47 KB, patch)
2012-11-06 10:31 PST, :aceman
acelists: review+
mconley: review+
Details | Diff | Splinter Review

Description User image :aceman 2012-11-05 03:38:25 PST
Remove the unused folderTargetPopup class and binding. It is now possible after bug 315367.^[^\0]*%24&hitlimit=&tree=comm-central

This can be done for both Thunderbird and Seamonkey.

Also add missing class="menulist-menupopup" to the menupopup searchWidgets.xml, binding id="ruleactiontarget-folder" which was recently converted away from class="folderTargetPopup".
Comment 1 User image :aceman 2012-11-05 12:39:36 PST
Created attachment 678426 [details] [diff] [review]
Comment 2 User image 2012-11-06 01:56:43 PST
Comment on attachment 678426 [details] [diff] [review]

>-        <xul:menupopup type="folder"
>+        <xul:menupopup class="menulist-menupopup"
>+                       type="folder"
No need to reorder the attributes, just add the class on its own line.
r=me with that fixed.
Comment 3 User image 2012-11-06 01:57:16 PST
(Also don't forget to port the class change to any appropriate branches.)
Comment 4 User image :aceman 2012-11-06 02:00:07 PST
Bug 315367 is in TB19 trunk, so no branches have it yet.
Comment 5 User image :aceman 2012-11-06 10:31:42 PST
Created attachment 678800 [details] [diff] [review]
patch v2

Comment 6 User image Ryan VanderMeulen [:RyanVM] 2012-11-06 14:34:57 PST
Comment 7 User image :aceman 2012-11-07 08:28:06 PST
Ryan, if it is possible to fix the checkin message, could you please remove mconley as did not review this.
Comment 8 User image Ryan VanderMeulen [:RyanVM] 2012-11-07 08:33:05 PST
I'd have to backout and re-land to do that. Is it really worth it?
Comment 9 User image :aceman 2012-11-07 08:38:34 PST
Comment on attachment 678800 [details] [diff] [review]
patch v2

So let's try to get his review and then we do not need to back out ;)
Comment 10 User image Mike Conley (:mconley) 2012-11-07 09:17:36 PST
Comment on attachment 678800 [details] [diff] [review]
patch v2

Review of attachment 678800 [details] [diff] [review]:

LGTM, thanks!

Note You need to log in before you can comment on or make changes to this bug.