808524 - remove unused folderTargetPopup class and binding

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

Remove the unused folderTargetPopup class and binding. It is now possible after bug 315367.

http://mxr.mozilla.org/comm-central/search?string=folderTargetPopup&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

This can be done for both Thunderbird and Seamonkey.

Also add missing class="menulist-menupopup" to the menupopup searchWidgets.xml, binding id="ruleactiontarget-folder" which was recently converted away from class="folderTargetPopup".

Comment 1

[:aceman]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 678426 [details] [diff] [review]
patch

>-        <xul:menupopup type="folder"
>+        <xul:menupopup class="menulist-menupopup"
>+                       type="folder"
No need to reorder the attributes, just add the class on its own line.
r=me with that fixed.

Comment 3

[[e-mail]]

(Also don't forget to port the class change to any appropriate branches.)

Comment 4

[:aceman]

Bug 315367 is in TB19 trunk, so no branches have it yet.

Comment 5

[:aceman]

Attachment: patch v2

Thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/73850fe23239

Comment 7

[:aceman]

Ryan, if it is possible to fix the checkin message, could you please remove mconley as did not review this.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

I'd have to backout and re-land to do that. Is it really worth it?

Comment 9

[:aceman]

Comment on attachment 678800 [details] [diff] [review]
patch v2

So let's try to get his review and then we do not need to back out ;)

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 678800 [details] [diff] [review]
patch v2

Review of attachment 678800 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!