The default bug view has changed. See this FAQ.

remove unused folderTargetPopup class and binding

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Backend
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 19.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

10.47 KB, patch
aceman
: review+
mconley
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
Remove the unused folderTargetPopup class and binding. It is now possible after bug 315367.

http://mxr.mozilla.org/comm-central/search?string=folderTargetPopup&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

This can be done for both Thunderbird and Seamonkey.

Also add missing class="menulist-menupopup" to the menupopup searchWidgets.xml, binding id="ruleactiontarget-folder" which was recently converted away from class="folderTargetPopup".
(Assignee)

Comment 1

4 years ago
Created attachment 678426 [details] [diff] [review]
patch
Attachment #678426 - Flags: review?(neil)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED

Comment 2

4 years ago
Comment on attachment 678426 [details] [diff] [review]
patch

>-        <xul:menupopup type="folder"
>+        <xul:menupopup class="menulist-menupopup"
>+                       type="folder"
No need to reorder the attributes, just add the class on its own line.
r=me with that fixed.
Attachment #678426 - Flags: review?(neil) → review+

Comment 3

4 years ago
(Also don't forget to port the class change to any appropriate branches.)
(Assignee)

Comment 4

4 years ago
Bug 315367 is in TB19 trunk, so no branches have it yet.
(Assignee)

Comment 5

4 years ago
Created attachment 678800 [details] [diff] [review]
patch v2

Thanks.
Attachment #678426 - Attachment is obsolete: true
Attachment #678800 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/73850fe23239
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
(Assignee)

Comment 7

4 years ago
Ryan, if it is possible to fix the checkin message, could you please remove mconley as did not review this.
I'd have to backout and re-land to do that. Is it really worth it?
(Assignee)

Comment 9

4 years ago
Comment on attachment 678800 [details] [diff] [review]
patch v2

So let's try to get his review and then we do not need to back out ;)
Attachment #678800 - Flags: review?(mconley)
Comment on attachment 678800 [details] [diff] [review]
patch v2

Review of attachment 678800 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #678800 - Flags: review?(mconley) → review+
You need to log in before you can comment on or make changes to this bug.