808527 - selectedBrowser frames appear when debugging chrome

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

STR:
1) Open the page inspector on any page.
2) Open the Browser Debugger.
3) Set a breakpoint in the first line of the CssRuleView constructor.
4) Close and reopen the page inspector.
4) Step-in repeatedly and observe the additional get_selectedBrowser frames that appear on the stack.

The fix will probably be to cache and not evaluate selectedBrowser in BRA_preNest and BRA_postNest.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

As far as I can tell this is all that we can do. Suspending events and timeouts in the selected content window isn't of much use for chrome debugging, if we can't do the same for chrome windows.

Comment 2

[Victor Porof [:vporof][:vp]]

This patch makes me happy.

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 678317 [details] [diff] [review]
Patch v1

Me too.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/8b22e64ff99e

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/8b22e64ff99e