808542 - [gcli] "addon list" output is malformed

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Alexander L. Slovesnik]

Attachment: Screenshot of bug

STR:
1) Open console
2) Enter "addon list"

Expected result:
Nicely formatted list of addons

Actual result:
See screnshot

Comment 1

[Paul Rouget [:paul]]

(s/console/gcli)

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

<![CDATA[add-on blah enabled]]>

Comment 4

[teramako]

Attachment: fix patch 1

* use context.createView() on "addon list"
 * rid "addon enable/disable" of CDATA section

Comment 5

[teramako]

I created patch (comment #4)
Could you review it.

Comment 6

[Joe Walker [:jwalker]]

Comment on attachment 687943 [details] [diff] [review]
fix patch 1

Review of attachment 687943 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.
r+ from me, but I'd like Mike to take a quick look as the author of this command.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 687943 [details] [diff] [review]
fix patch 1

Looks great, r+ from me

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ef3ec5487993