808611 - Reimplement valueOf shadowing protection using IDL

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

This is a less-brittle fix to bug 793969.

Comment 1

[Bobby Holley (:bholley)]

This doesn't actually depend on the wrapper caching. Not sure what I was thinking.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Move valueOf to nsIDOMLocation. v1

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 678381 [details] [diff] [review]
Move valueOf to nsIDOMLocation. v1

Review of attachment 678381 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsLocation.cpp
@@ +915,5 @@
>  
> +NS_IMETHODIMP
> +nsLocation::ValueOf(nsIDOMLocation** aReturn)
> +{
> +  nsCOMPtr<nsIDOMLocation> loc(this);

loc = this

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 678381 [details] [diff] [review]
Move valueOf to nsIDOMLocation. v1

>-    "valueOf",              // IDX_VALUE_OF
>-        IDX_VALUE_OF                ,
Isn't it required to create an interned string early?
For example, IDX_OBJECT is not used at all other than creating an interned string.
https://mxr.mozilla.org/mozilla-central/search?string=IDX_OBJECT

Comment 5

[Bobby Holley (:bholley)]

(In reply to Masatoshi Kimura [:emk] from comment #4)
> Comment on attachment 678381 [details] [diff] [review]
> Move valueOf to nsIDOMLocation. v1
> 
> >-    "valueOf",              // IDX_VALUE_OF
> >-        IDX_VALUE_OF                ,
> Isn't it required to create an interned string early?
> For example, IDX_OBJECT is not used at all other than creating an interned
> string.
> https://mxr.mozilla.org/mozilla-central/search?string=IDX_OBJECT

I added those strings a few weeks ago in bug 793969, so my guess is that they're not critical.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 678381 [details] [diff] [review]
Move valueOf to nsIDOMLocation. v1

Slick.

Comment 7

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/292958cd0d42

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/292958cd0d42

Should this have a test?

Comment 9

[Bobby Holley (:bholley)]

(In reply to Ryan VanderMeulen from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/292958cd0d42
> 
> Should this have a test?

The relevant test here was checked in in bug 793969.