808650 - [email] contact list do not distinguish between contacts with email and without

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Pablo Sanchez [:pabloUX]]

currently, contact list when you are adding e-mail recipents is complete, so If you want to add an email you should try in order to know if the email info is added to the contact details.

Comment 1

[Casey Yee]

Contacts without emails should not show up in contacts selection list if there is no email address associated with the contact.

Comment 2

[Josh Carpenter [:jcarpenter]]

Andrew, can you comment on feasibility?

Comment 3

[Kevin Grandon :kgrandon]

Appears to only be a problem with the contacts app, and the fix doesn't seem to be too difficult. I'll take a stab as this has sat for a few months now...

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Pull request to filter for contacts with email addresses.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 703303 [details]
Github pull request pointer

Looking for a review here if possible, thanks!

Comment 6

[ayman maat :maat]

[TEF_REQ] as Feature required for TEF build.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 703303 [details]
Github pull request pointer

It's been 2 weeks and I'm technically a peer of gaia and this seems like a very small/straightforward patch, so r=asuth.

Comment 8

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/49f1c92638c01ab7696765c226bbca13c4f86d7d

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

This has a fix and is a TEF_REQ; can we land this on v1.0.0 and/or v1-train?

Comment 10

[Daniel Coloma:dcoloma]

(In reply to Andrew Sutherland (:asuth) from comment #9)
> This has a fix and is a TEF_REQ; can we land this on v1.0.0 and/or v1-train?

Andrew, I think this is not a blocker as this would not block the release. However, I'd suggest you request directly gaia-approval (and tracking-b2g18 if you want). Given how small the change is and the low risk it has I think it is highly likely triagers accept this to go to v1-train.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 703303 [details]
Github pull request pointer

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Contact list will show contacts in the address book without e-mail addresses.  We think this would be great on v1.0.0 too since it's TEF_REQ.
Testing completed: Kevin!
Risk to taking this patch (and alternatives if risky): Not believed risky, patch is tiny.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 703303 [details]
Github pull request pointer

Sounds good to me but I believe you need to have a tef+ approval to land on 1.0.0. Is that what you're trying to achieve?

Comment 13

[Daniel Coloma:dcoloma]

For Telefónica, landing it in v1-train is enough.

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: baf2dcafc5d14f532459fb7c8c59e6f8f1ac6712

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1