808659 - BaselineCompiler: rm IonBaselineJSFrameLayout

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

I added it to the prototype but I hope we won't need it and can just use IonJSFrameLayout, to simplify cross-JIT calls, frame iteration etc.

Comment 1

[Kannan Vijayan [:djvj]]

Comment on attachment 678369 [details] [diff] [review]
Patch

Review of attachment 678369 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonFrameIterator.h
@@ +111,5 @@
>      bool checkInvalidation(IonScript **ionScript) const;
>      bool checkInvalidation() const;
>  
>      bool isScripted() const {
> +        return type_ == IonFrame_BaselineJS || type_ == IonFrame_JS;

Why are we adding this check here?  From the patch I expected that IonFrame_BasineJS was going to be removed entirely.

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Kannan Vijayan [:djvj] from comment #1)
> 
> Why are we adding this check here?  From the patch I expected that
> IonFrame_BasineJS was going to be removed entirely.

The frame prefix/header will be the same, but the frame descriptor has to be different so that we know whether it's a baseline or optimized frame. We have to know this for GC and frame iteration (I renamed IonFrame_JS to IonFrame_OptimizedJS on m-c, these frames have snapshots and inline frames etc).

Comment 3

[Kannan Vijayan [:djvj]]

Ah, ok.  Got it.

Comment 4

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/projects/ionmonkey/rev/9e51322230ac