BaselineCompiler: rm IonBaselineJSFrameLayout

RESOLVED FIXED

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 678369 [details] [diff] [review]
Patch

I added it to the prototype but I hope we won't need it and can just use IonJSFrameLayout, to simplify cross-JIT calls, frame iteration etc.
Attachment #678369 - Flags: review?(kvijayan)
Comment on attachment 678369 [details] [diff] [review]
Patch

Review of attachment 678369 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonFrameIterator.h
@@ +111,5 @@
>      bool checkInvalidation(IonScript **ionScript) const;
>      bool checkInvalidation() const;
>  
>      bool isScripted() const {
> +        return type_ == IonFrame_BaselineJS || type_ == IonFrame_JS;

Why are we adding this check here?  From the patch I expected that IonFrame_BasineJS was going to be removed entirely.
(Assignee)

Comment 2

6 years ago
(In reply to Kannan Vijayan [:djvj] from comment #1)
> 
> Why are we adding this check here?  From the patch I expected that
> IonFrame_BasineJS was going to be removed entirely.

The frame prefix/header will be the same, but the frame descriptor has to be different so that we know whether it's a baseline or optimized frame. We have to know this for GC and frame iteration (I renamed IonFrame_JS to IonFrame_OptimizedJS on m-c, these frames have snapshots and inline frames etc).
Ah, ok.  Got it.

Updated

6 years ago
Attachment #678369 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/9e51322230ac
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.