808676 - [Status Bar] Notification Count is 2 pixels too low

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: in builds...

Can you please move the notification count UP by 2 pixels

Comment 2

[Patryk Adamczyk [:patryk] UX]

P2 cause its an issue fix and affects EVERY app.

Comment 3

[Sam Joch [:samjoch]]

Attachment: Patch that adds 2px to notifications count

Comment 4

[Gordon Brander :gordonb]

Merged into UX Branch https://github.com/gordonbrander/gaia/commit/8bfb812be56e19f79062264b8659bdba9e1da103

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

:gbrander are you taking this bug?

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

I'm not sure if I see the difference.

Comment 7

[Gordon Brander :gordonb]

(In reply to Naoki Hirata :nhirata from comment #6)
> I'm not sure if I see the difference.

It's for the notification count in the status bar (see https://bugzilla.mozilla.org/attachment.cgi?id=678377, upper left-hand corner for incorrect implementation).

FWIW, I've verified on device. Sam Joch should be able to help you reproduce. Thanks!

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oh!  looked at the wrong spot.  Thanks Gordon!  Verified.

commit 4f48eafeaf6d5f58afbd67b36a68eff4af579be0

Looks like there might be some other issues in this gaia build though.  It might be master.  I'll file bugs separate after checking them out in master.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/06b3a1567011130b0467a43b9075196ff60b43ee

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Master build : 2013-03-25-03-07-06
"mozilla-central" revision="bef19bca23f9"
"integration/gaia-central" revision="8c401e09a6a9"
"gecko.git"revision="bbaac6bbbf5084ef1a3e178ced676ea77db8b24b"
"gaia.git" revision="a1259a6c80629daa458428d6a96403841aaab0f0"

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/dec694d585e1
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
BuildID 20130325070203
Version 18.0
Unagi

Note: code switch from px to rem