808691 - The remote and chrome debugger windows should remember their size across sessions

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Quick and easy.

Notes:
* In order to save the window dimensions, the chrome debugger profile no longer gets deleted after the process is killed. Moreover, a new profile isn't created again the next time we start a new process.
* I made the pref handling inside the controller more awesome.
* The remote and chrome window dimensions are considered the same thing.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 678670 [details] [diff] [review]
v1

Review of attachment 678670 [details] [diff] [review]:
-----------------------------------------------------------------

Window size persistence is fine, but with this patch I can no longer start Browser Debugger if I remove the existing chrome-debugger profiles beforehand.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 678670 [details] [diff] [review]
> v1
> 
> Review of attachment 678670 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Window size persistence is fine, but with this patch I can no longer start
> Browser Debugger if I remove the existing chrome-debugger profiles
> beforehand.

I guess by "remove" you mean simply deleting the folder, not removing the profile via the ProfileManager, right? In that case, a workaround may not be trivial to find, since the profile still appears as existing, even though the files are deleted. Maybe I can check OS.Constants.Path.profileDir or something.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 678670 [details] [diff] [review]
v1

Review of attachment 678670 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Victor Porof [:vp] from comment #3)
> (In reply to Panos Astithas [:past] from comment #2)
> > Window size persistence is fine, but with this patch I can no longer start
> > Browser Debugger if I remove the existing chrome-debugger profiles
> > beforehand.
> 
> I guess by "remove" you mean simply deleting the folder, not removing the
> profile via the ProfileManager, right? In that case, a workaround may not be
> trivial to find, since the profile still appears as existing, even though
> the files are deleted. Maybe I can check OS.Constants.Path.profileDir or
> something.

Ah, good point! I guess we can expect users to use the password manager for this.

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #4)
> Comment on attachment 678670 [details] [diff] [review]
> v1
> 
> Review of attachment 678670 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to Victor Porof [:vp] from comment #3)
> > (In reply to Panos Astithas [:past] from comment #2)
> > > Window size persistence is fine, but with this patch I can no longer start
> > > Browser Debugger if I remove the existing chrome-debugger profiles
> > > beforehand.
> > 
> > I guess by "remove" you mean simply deleting the folder, not removing the
> > profile via the ProfileManager, right? In that case, a workaround may not be
> > trivial to find, since the profile still appears as existing, even though
> > the files are deleted. Maybe I can check OS.Constants.Path.profileDir or
> > something.
> 
> Ah, good point! I guess we can expect users to use the password manager for
> this.

Well, the behavior you're describing is still suboptimal. I never use the profile manager to delete stuff. I suppose other power users don't either. I'll try to find a solution before landing this.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

I'll just note that after properly deleting the profiles from the profile manager, I no longer get the error on profile creation that I used to get the first time I launch the chrome debugger.

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v2

This wasn't entirely hard..

Managing chrome debugger profiles is now entirely failproof afaict. Panos, you be the judge!

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 678770 [details] [diff] [review]
v2

Review of attachment 678770 [details] [diff] [review]:
-----------------------------------------------------------------

OK, looks good.

Comment 9

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/1f5b1a3d50d1

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f5b1a3d50d1