808847 - Work - For WinRT touch input, do not send mouse events except when a single-tap is detected

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Matt Brubeck (:mbrubeck)]

Currently on Metro, every pointer press or release results in a mouseup or mousedown event, even for touch or stylus pointers.  Instead, we should dispatch mouse events only if the pointer is a physical mouse, or (for compatibility) when we detect a "tap" gesture from a non-mouse pointer.

This matches the expected behavior of touch events and mouse events expected by web content, so that we can get rid of our front-end input filtering (bug 794621) and just let Gecko dispatch events directly to content.

Comment 1

[Jim Mathies [:jimm]]

I think we should include pen input in the mouse category, since it's precise input. thoughts?

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch v.1

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Jim Mathies [:jimm] from comment #1)
> I think we should include pen input in the mouse category, since it's
> precise input. thoughts?

I was thinking pen input would be treated like touch since it probably has similar gestures (I'm assuming that "tap and hold" is the "right-click" gesture for pen)

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: WIP patch

Per discussion at the metro dev meeting and in #windev, I'm nabbing this bug.  The attached patch incorporates Jim's changes, as well as including support for touch events (patch from bug 745071 ported to VS2010).  It needs to be cleaned up (add comments, make sure all events are sent correctly, etc), but it passes my preliminary testing

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Adding metro-it1 since I'm working on this presently

Comment 6

[Jim Mathies [:jimm]]

Can we get an updated patch merged to elm tip for testing bug 794621?

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 681219 [details] [diff] [review]
WIP patch

Please look at bug 794621 for updated patches that include a fix for this bug.

Comment 8

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

The patches in bug 794621 have been submitted to elm.  The patch that contains the changes for this bug is:
https://hg.mozilla.org/projects/elm/rev/e38fa39ccf69

This build contains the changes:
https://tbpl.mozilla.org/?tree=Elm&rev=e38fa39ccf69

Comment 9

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Marking my [completed-elm] bugs as resolved