808866 - do not create location providers in child process

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Currently, we are creating geo providers in the child process.  We shouldn't do that.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 678570 [details] [diff] [review]
patch v.1

Review of attachment 678570 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see how this can work. sGeoInitPending starts as true, and this patch early returns before any settings check occurs that can change that value. When we trigger an IPC content permission prompt, eventually we get an Allow repsonse which early returns because sGeoInitPending is still true, so we never reach StartDevice and never create the IPC geolocation update listeners.

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 678570 [details] [diff] [review]
patch v.1

Yeah, next time I'll review the actual patch, as opposed to what my brain thinks it contains.

Comment 4

[Doug Turner (:dougt)]

This needs to be fixed or all geo apps will be killed on geo usage (see bug 808327)

Comment 5

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/dbeaa765933e
https://hg.mozilla.org/releases/mozilla-aurora/rev/929f506750e1