Closed Bug 808875 Opened 7 years ago Closed 7 years ago

Fix -Wunused-variable warnings on android build

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: kats, Assigned: gw280)

References

(Blocks 1 open bug)

Details

(Whiteboard: [leave open])

Attachments

(6 files, 2 obsolete files)

Attached patch (1/8) ElfLoader.cpp (obsolete) — Splinter Review
My (incremental) build of android has 14 -Wunused-variable warnings, which takes just about as long to fix as it takes for my build to complete. Figured this is more productive than swordfighting on wheelie chairs.

Try build in progress at https://tbpl.mozilla.org/?tree=Try&rev=d17490378045
Attachment #678578 - Flags: review?(mh+mozilla)
Comment on attachment 678578 [details] [diff] [review]
(1/8) ElfLoader.cpp

Review of attachment 678578 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/ElfLoader.cpp
@@ -232,5 @@
>          return *it;
>    }
>  
>    char *abs_path = NULL;
> -  const char *requested_path = path;

path may change later on, and it's not the changed value that i want logged.
Attachment #678578 - Flags: review?(mh+mozilla) → review-
Comment on attachment 678585 [details] [diff] [review]
(8/8) Assembler-arm.cpp

Review of attachment 678585 [details] [diff] [review]:
-----------------------------------------------------------------

I would have preferred being challenged to a foam-sword duel, but this is also acceptable.
Attachment #678585 - Flags: review?(mrosenberg) → review+
Assignee: nobody → bugmail.mozilla
Attachment #678584 - Flags: review?(wjohnston) → review?(benjamin)
Attachment #678579 - Flags: review?(mwu) → review+
Attachment #678584 - Flags: review?(benjamin) → review+
I'm just gonna start landing the patches as they r+'d because otherwise they'll just be sitting around forever and get bitrotted. Enemy of the good and all that.

Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/11b76ebcd3c2
Part 7: https://hg.mozilla.org/integration/mozilla-inbound/rev/70e8cf8dd277
Part 8: https://hg.mozilla.org/integration/mozilla-inbound/rev/de3ede8ff84d
Whiteboard: [leave open]
Comment on attachment 678583 [details] [diff] [review]
(6/8) nsSmartCardMonitor.cpp

This patch is obsoleted by bug 817176.
Attachment #678583 - Attachment is obsolete: true
Attachment #678583 - Flags: review?(bsmith)
Comment on attachment 678578 [details] [diff] [review]
(1/8) ElfLoader.cpp

This patch is obsoleted by bug 830326.
Attachment #678578 - Attachment is obsolete: true
Waiting on :gw280 for the rest of these.
Assignee: bugmail.mozilla → gwright
Attachment #678580 - Flags: review?(gwright)
Attachment #678581 - Flags: review?(gwright)
Attachment #678582 - Flags: review?(gwright)
I built with -Werror for Skia and didn't run into any of these issues, so I think we can close this.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.