808875 - Fix -Wunused-variable warnings on android build

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/8) ElfLoader.cpp

My (incremental) build of android has 14 -Wunused-variable warnings, which takes just about as long to fix as it takes for my build to complete. Figured this is more productive than swordfighting on wheelie chairs.

Try build in progress at https://tbpl.mozilla.org/?tree=Try&rev=d17490378045

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/8) file_util_posix.cc

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: (3/8) SkBitmapProcState_matrix.h

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: (4/8) SkThread_pthread.cpp

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: (5/8) SkFontHost_FreeType.cpp

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: (6/8) nsSmartCardMonitor.cpp

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: (7/8) nsAppRunner.cpp

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: (8/8) Assembler-arm.cpp

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 678578 [details] [diff] [review]
(1/8) ElfLoader.cpp

Review of attachment 678578 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/ElfLoader.cpp
@@ -232,5 @@
>          return *it;
>    }
>  
>    char *abs_path = NULL;
> -  const char *requested_path = path;

path may change later on, and it's not the changed value that i want logged.

Comment 9

[Marty Rosenberg [:mjrosenb]]

Comment on attachment 678585 [details] [diff] [review]
(8/8) Assembler-arm.cpp

Review of attachment 678585 [details] [diff] [review]:
-----------------------------------------------------------------

I would have preferred being challenged to a foam-sword duel, but this is also acceptable.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I'm just gonna start landing the patches as they r+'d because otherwise they'll just be sitting around forever and get bitrotted. Enemy of the good and all that.

Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/11b76ebcd3c2
Part 7: https://hg.mozilla.org/integration/mozilla-inbound/rev/70e8cf8dd277
Part 8: https://hg.mozilla.org/integration/mozilla-inbound/rev/de3ede8ff84d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11b76ebcd3c2
https://hg.mozilla.org/mozilla-central/rev/70e8cf8dd277
https://hg.mozilla.org/mozilla-central/rev/de3ede8ff84d

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 678583 [details] [diff] [review]
(6/8) nsSmartCardMonitor.cpp

This patch is obsoleted by bug 817176.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 678578 [details] [diff] [review]
(1/8) ElfLoader.cpp

This patch is obsoleted by bug 830326.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Waiting on :gw280 for the rest of these.

Comment 15

[George Wright (:gw280) (needinfo me!)]

I built with -Werror for Skia and didn't run into any of these issues, so I think we can close this.