808951 - Panda (Android 4.0) jobs for reftest and jsreftest pending forever.

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

Sooo, I noticed this evening that though we had every panda in production as idle, we still had every single reftest and jsreftest job on cedar as pending, along with the builders still being shown in the buildbot UI.

After a bit of "how can this be" I thought and noticed the "nextOldTegra" hack we have, is busted for Pandas.

I don't think this should block anything short-term right now, but will arbitrarily inflate our panda wait times report and pending job count. And I will address this with a patch sometime on Tuesday, however if someone wants to steal it from me go ahead.

What we need to change is:
http://mxr.mozilla.org/build/source/buildbotcustom/misc.py#396

Specifically we do |number = s.slave.slavename.replace('tegra-', '')| and then try to convert the result to an int(), which will fail if the device name is 'panda-NNNN' of course.

Suggest something [untested] like 
if 'panda-' in s.slave.slavename:
  old.append(s)
  continue

above the number =...

Though there are probably other just-as-good ways to fix this.

Comment 1

[Justin Wood (:Callek)]

Attachment: [custom] v1

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 678928 [details] [diff] [review]
[custom] v1

This is still ugly =\

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 678928 [details] [diff] [review]
[custom] v1

Review of attachment 678928 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/build/buildbotcustom/rev/ec73b52877af

Comment 4

[Rail Aliiev [:rail]]

in production