12.91 KB, image/png
11.44 KB, image/png
2.99 KB, patch
|Details | Diff | Splinter Review|
Created attachment 678659 [details] screenshot of how the Recent folders has different style Found in bug 315367 comment 51. The recent submenu of file picker widget may have a different style to the parent folder. The submenus (folders) of normal accounts do inherit the parent menu's style, but Recent does not. See the attached screenshots.
Created attachment 678660 [details] screenshot of how the normal subfolders have the same style as the parent
Created attachment 678823 [details] [diff] [review] patch Should be tested on Win/Mac, on Linux I see no difference (all the pickers are grey, on Win some are white).
Comment on attachment 678823 [details] [diff] [review] patch So, on Mac, I'm not a fan of this change. Check out the screenshot at https://dl.dropbox.com/u/2301433/Screenshots/SmallFolders.png I think the sub-menus should be in the bigger font. Now, perhaps we should just set the class, and do this in the CSS, but I would like to see this fixed before I give it a ui-r+. (Feel free to ping Paenglab, if you don't feel like mucking around in the CSS yourself. ;) Thanks, Blake.
Hey, this patch only affects the Recent menu. You can't lookup random bugs in the style of the submenu of the account items :) Or I don't understand what you see. Please show me all those 3 submenus before the patch and after the patch (so 6 images), not a mixture of each place showing with using different code (before or after patch) ;) Also you must compare the submenus inside one picker (this bug should make the font the same in Recent submenu and the account submenus), not between different dialogs. Each of them may be setting a different class of it.
Sure, but I think all the other menus should act like the Recent menu currently does, not the other way around, which means removing the class from the other menus, not adding the class to the Recent menu.
Created attachment 680701 [details] [diff] [review] patch 2 (alternative) But if you want to get all pickers in all dialogs to have the same style then I can add class="menulist-menupopup" where it is missing (e.g. in the filter list "run filters on" picker). You can try with this patch both of the pickers in the filter list dialog and the one in the filter editor. But test it on all platforms.
Trying it on Linux is a giant pain for me, could I get you to post screenshots of that platform, and I'll try it on Windows and Mac?
Indeed, the menulist-menupopup class is missing from Thunderbird's version of the filter list dialog.
None of the patches changes anything on Linux so no screenshot needed :) It seems the default style is a heavy grey menu with 3d border and that is what is used on all pickers. Also the menulist-menupopup class looks the same. Only Windows and Mac have this thin white menu. But the Recent submenu was grey on Windows before the patch. If the actual style specified in the class is not what you want then that is a different problem, we can do it but first need to get all the pickers to use the same class (patch 2 is a start for the filters dialog). Thanks for confirmation Neil. I've added them in patch 2.
Comment on attachment 680701 [details] [diff] [review] patch 2 (alternative) Looks good on Mac, looks good on Windows. There's another bug, but I'll file that separately and cc you. In the meantime, r=me.
Comment on attachment 680701 [details] [diff] [review] patch 2 (alternative) OK, so let's continue with this version.
Comment on attachment 680701 [details] [diff] [review] patch 2 (alternative) Oh, bwinton gave r+ too :) And for the code change we have r+ from Neil.