809071 - Delay and try deleting profile directory again

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Sleep and try again after profile deletion failure, v1

And around the xpcshell test IOError carousel we go again.

My next shot in the dark is to wait a few seconds after the first IOError and try again. The theory is that the system call has completed but the OS/filesystem is still doing work under the hood which prevents subsequent operations from working.

Comment 1

[Ed Morley [:emorley]]

Ted, ping for review (this is blocking our #1 toporange at the moment, bug 752243).

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 678769 [details] [diff] [review]
Sleep and try again after profile deletion failure, v1

Review of attachment 678769 [details] [diff] [review]:
-----------------------------------------------------------------

Horrible. If this fixes the issue then we should try to find a cleaner way to do this. (Is there really no way to delete a directory tree reliably?)

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/104e49ae05f4

Comment 4

[Ed Morley [:emorley]]

Had an occurrence after this landed:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16959208&tree=Mozilla-Inbound
(bug 762032 comment 113)

Comment 5

[Gregory Szorc [:gps]]

I'm inclined to believe permissions issues on Windows due to the updater service/process might be a separate bug from bug the necko cache and 752243. So, let's wait and see what happens with bug 752243.

Comment 6

[Gregory Szorc [:gps]]

From https://tbpl.mozilla.org/php/getParsedLog.php?id=16969013&full=1&branch=mozilla-inbound:

TEST-PASS | /builds/slave/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_service_createAccount.js | test passed (time: 917.873ms)
TEST-INFO | Failed to remove profile directory. Waiting.
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_service_createAccount.js | Failed to clean up the test profile directory: [Errno 13] Permission denied: '/var/folders/s1/zw9hr_nx645fs_fbl2vmsv_h00000w/T/tmpEH2mXg/Cache/4'
>>>>>>>

Well, shit.

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/104e49ae05f4