809109 - Expose timeout parameter to all devicemanager commands

Status: RESOLVED WONTFIX

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

In dmADB the _checkCmd method has a timeout parameter that defaults to 300 seconds. But if you call e.g pushFile, there is no way to pass in a custom timeout. We should add the timeout property to all of the various commands that are built on top of _checkCmd.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: add timeout parameter to dmADB methods that use checkCmd

I tried to see if I can pull out the timeout parameter in the abstract dm.py but the dmSUT implementation is quite different with regard to wrapped low level functions (for example even dirExists might end up having a timeout parameter which I'm not sure is desired).

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 691539 [details] [diff] [review]
add timeout parameter to dmADB methods that use checkCmd

Review of attachment 691539 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, though I didn't go into the source looking for other missed instances or anything. I don't think there is a burning need for this so feel free to leave it on the backburner unless you want some work to do :)

Comment 3

[Geoff Brown [:gbrown]]

Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.