809140 - PGO build failures related to command execute handler

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jim Mathies [:jimm]]

This looks like packager problems. We have PGO disabled on elm for now. The part that breaks down is:

Missing file(s): ..\..\dist\bin\CommandExecuteHandler.exe

Which should be present, but maybe ..\..\dist\bin isn't where we expect it to be?

Packaging JavaScript Shell...
e:\builds\moz2_slave\elm-w32-ntly\build\toolkit\mozapps\installer\packager.mk:890:0$ rm -f ../../dist/jsshell-win32.zip
e:\builds\moz2_slave\elm-w32-ntly\build\toolkit\mozapps\installer\packager.mk:891:0$ zip -9j ../../dist/jsshell-win32.zip ../../dist/bin/js.exe ../../dist/bin/mozglue.dll  ../../dist/bin/nspr4.dll ../../dist/bin/msvcr100.dll
  adding: js.exe (172 bytes security) (deflated 61%)
  adding: mozglue.dll (172 bytes security) (deflated 49%)
  adding: nspr4.dll (172 bytes security) (deflated 54%)
  adding: msvcr100.dll (172 bytes security) (deflated 46%)
e:\builds\moz2_slave\elm-w32-ntly\build\toolkit\mozapps\installer\packager.mk:755:0$ e:/builds/moz2_slave/elm-w32-ntly/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/elm-w32-ntly/build/toolkit/mozapps/installer/packager.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -D_MSC_VER=1600 -DJAREXT= -DMOZ_ANGLE_RENDERER=1 -DMOZ_D3DX9_DLL=d3dx9_43.dll -DMOZ_D3DCOMPILER_DLL=D3DCompiler_43.dll -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_MSVC_REDIST=1600 -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin --format omni --removals e:/builds/moz2_slave/elm-w32-ntly/build/browser/installer/removed-files.in e:/builds/moz2_slave/elm-w32-ntly/build/browser/installer/package.manifest ../../dist/bin ../../dist/firefox
e:\builds\moz2_slave\elm-w32-ntly\build\toolkit\mozapps\installer\packager.mk:755:0: command 'e:/builds/moz2_slave/elm-w32-ntly/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/elm-w32-ntly/build/toolkit/mozapps/installer/packager.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -D_MSC_VER=1600 -DJAREXT= -DMOZ_ANGLE_RENDERER=1 -DMOZ_D3DX9_DLL=d3dx9_43.dll -DMOZ_D3DCOMPILER_DLL=D3DCompiler_43.dll -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_MSVC_REDIST=1600 -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin --format omni --removals e:/builds/moz2_slave/elm-w32-ntly/build/browser/installer/removed-files.in e:/builds/moz2_slave/elm-w32-ntly/build/browser/installer/package.manifest ../../dist/bin ../../dist/firefox' failed, return code 1
e:\builds\moz2_slave\elm-w32-ntly\build\config\rules.mk:556:0: command 'C:/mozilla-build/buildbotve/scripts/python.exe e:/builds/moz2_slave/elm-w32-ntly/build/build/pymake/pymake/../make.py libs' failed, return code 2
e:\builds\moz2_slave\elm-w32-ntly\build\browser\build.mk:47:0: command 'C:/mozilla-build/buildbotve/scripts/python.exe e:/builds/moz2_slave/elm-w32-ntly/build/build/pymake/pymake/../make.py -C browser/installer' failed, return code 2
e:\builds\moz2_slave\elm-w32-ntly\build\client.mk:197:0: command 'C:/mozilla-build/buildbotve/scripts/python.exe e:/builds/moz2_slave/elm-w32-ntly/build/build/pymake/pymake/../make.py -C obj-firefox package MOZ_PGO_INSTRUMENTED=1 MOZ_INTERNAL_SIGNING_FORMAT= MOZ_EXTERNAL_SIGNING_FORMAT=' failed, return code 2
e:\builds\moz2_slave\elm-w32-ntly\build\client.mk:152:0: command 'C:/mozilla-build/buildbotve/scripts/python.exe e:/builds/moz2_slave/elm-w32-ntly/build/build/pymake/pymake/../make.py -f e:/builds/moz2_slave/elm-w32-ntly/build/client.mk profiledbuild' failed, return code 2
</span><span class="stderr">res/spacetrace.css was not registered
Missing file(s): ..\..\dist\bin\CommandExecuteHandler.exe
Traceback (most recent call last):
  File &#34;e:/builds/moz2_slave/elm-w32-ntly/build/toolkit/mozapps/installer/packager.py&#34;, line 600, in &lt;module&gt;
    main()
  File &#34;e:/builds/moz2_slave/elm-w32-ntly/build/toolkit/mozapps/installer/packager.py&#34;, line 586, in main
    packager.finalize()
  File &#34;e:/builds/moz2_slave/elm-w32-ntly/build/toolkit/mozapps/installer/packager.py&#34;, line 547, in finalize
    Packager.finalize(self)
  File &#34;e:/builds/moz2_slave/elm-w32-ntly/build/toolkit/mozapps/installer/packager.py&#34;, line 357, in finalize
    self.copier.finalize()
  File &#34;e:/builds/moz2_slave/elm-w32-ntly/build/toolkit/mozapps/installer/packager.py&#34;, line 180, in finalize
    raise Exception, &#39;Aborting due to errors&#39;
Exception: Aborting due to errors
</span><span class="header">program finished with exit code 2

Comment 1

[Mike Hommey [:glandium]]

(In reply to Jim Mathies [:jimm] from comment #0)
> This looks like packager problems. We have PGO disabled on elm for now. The
> part that breaks down is:
> 
> Missing file(s): ..\..\dist\bin\CommandExecuteHandler.exe
> 
> Which should be present, but maybe ..\..\dist\bin isn't where we expect it
> to be?

I don't think that file is in PGO builds only. It should fail equally on non PGO builds... maybe non PGO builds don't have an installer?

Comment 2

[Mike Hommey [:glandium]]

Ah, that's a metro-only install rule.
https://hg.mozilla.org/projects/elm/file/e5d4e479e4af/browser/installer/package.manifest#l318

Comment 3

[Mike Hommey [:glandium]]

I think the problem come from:
https://hg.mozilla.org/projects/elm/file/e5d4e479e4af/browser/metro/shell/commandexecutehandler/Makefile.in lines 12 and 14.

Remove line 12 (PROGRAMS_DEST = $(DIST)/bin) and replace SIMPLE_PROGRAMS with PROGRAM.

Comment 4

[Jim Mathies [:jimm]]

<glandium> jimm: and i think that's the problem. i just commented on the bug
<mbest> mbrubeck: feel free to follow up with catlee if you have objections, otherwise they will go ahead unless they hear a reason to stop their plan.
<jimm> glandium: so PROGRAMS_DEST is bad?
<glandium> jimm: no, SIMPLE_PROGRAMS is.
<glandium> jimm: ah, since you want the program to be in dist/bin, you'll want to set DIST_SUBDIR =
<bbondy> good re: v1 e10s :)
<glandium> jimm: essentially, SIMPLE_PROGRAMS are not built during the first pass of PGO. And PGO builds do package at the end of the first pass.
<jimm> I see

Comment 5

[Jim Mathies [:jimm]]

Attachment: fix v.1

This worked in a local build, although I have not tried a local PGO build yet.

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/dca8d2a4c657

Comment 7

[Armen [:armenzg]]

Hi jimm,
I've found that PGO does not work on staging.
Would you mind having a look at it?
http://people.mozilla.com/~armenzg/incoming/elm.pgo.txt

LINK : fatal error LNK1266: error reading instrumentation file 'linktool.pgd'; File not found^M

Comment 8

[Jim Mathies [:jimm]]

(In reply to Armen Zambrano G. [:armenzg] from comment #7)
> Hi jimm,
> I've found that PGO does not work on staging.
> Would you mind having a look at it?
> http://people.mozilla.com/~armenzg/incoming/elm.pgo.txt
> 
> LINK : fatal error LNK1266: error reading instrumentation file
> 'linktool.pgd'; File not found^M

Hmm looks similar to the command execute handler problem, although linktool.exe isn't distributed with the install. It is packaged in zip builds though.

I've got a pgo build going on my tablet, we'll see how far it gets.

Comment 9

[Mike Hommey [:glandium]]

That's a different one. It means there was no pgo info to rebuild the binary, which means the binary wasn't executed for a profile, which is not unexpected, since only firefox is being run for a profile. Just add NO_PROFILE_GUIDED_OPTIMIZE = 1 to the Makefile.in that defines linktool as a PROGRAM.

Comment 10

[Jim Mathies [:jimm]]

Attachment: follow up

Comment 11

[Jim Mathies [:jimm]]

(In reply to Mike Hommey [:glandium] from comment #9)
> That's a different one. It means there was no pgo info to rebuild the
> binary, which means the binary wasn't executed for a profile, which is not
> unexpected, since only firefox is being run for a profile. Just add
> NO_PROFILE_GUIDED_OPTIMIZE = 1 to the Makefile.in that defines linktool as a
> PROGRAM.

ah ok. would that also work for metrotestharness.exe which we only use when running tests?

Comment 12

[Jim Mathies [:jimm]]

Attachment: follow up

Comment 13

[Jim Mathies [:jimm]]

Attachment: follow up

3rd time's the charm.

Comment 14

[Mike Hommey [:glandium]]

Comment on attachment 679210 [details] [diff] [review]
follow up

Review of attachment 679210 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/shell/commandexecutehandler/Makefile.in
@@ +14,5 @@
> +
> +# We want this exe in dist/bin
> +DIST_SUBDIR =
> +
> +PROGRAM = CommandExecuteHandler$(BIN_SUFFIX)

How come these lines are in the diff?

Comment 15

[Jim Mathies [:jimm]]

(In reply to Mike Hommey [:glandium] from comment #14)
> Comment on attachment 679210 [details] [diff] [review]
> follow up
> 
> Review of attachment 679210 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/metro/shell/commandexecutehandler/Makefile.in
> @@ +14,5 @@
> > +
> > +# We want this exe in dist/bin
> > +DIST_SUBDIR =
> > +
> > +PROGRAM = CommandExecuteHandler$(BIN_SUFFIX)
> 
> How come these lines are in the diff?

windows line ending cleanup from the last patch. :/

Comment 16

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/5d30ed7651ca