809185 - Pressly toolkit has progressive drawing artifacts when panning

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Benoit Girard (:BenWa)]

STR:
1) Go to: http://staging-api.pressly.com/thestar/www/?debug=true#!/section/toc
2) Fling to the left. Note that this isn't a PZC scroll but I believe it's a scripted translation.

This may be fixed by fixing bug 809132 but I'm a bit concerned to see progressive drawing artifacts when we aren't panning.

Comment 1

[Benoit Girard (:BenWa)]

Looks like we no longer have code in place to avoid progressively drawing new content when not panning. I can't remenber if we had a good reason to remove it. Chris?

Comment 2

[Benoit Girard (:BenWa)]

Attachment: Don't use progressive drawing if not panning

Comment 3

[Benoit Girard (:BenWa)]

review ping

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 679283 [details] [diff] [review]
Don't use progressive drawing if not panning

Review of attachment 679283 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is fine, but I'd prefer a solution that retained as much progressive rendering as possible. Rather than not progressive rendering at all when scrolling, how about we draw visible content progressively, but in a single transaction? i.e. treat visible content as if it was stale if we're not scrolling.

This should have the same effect as this, but allow any content that doesn't intersect with the screen to be drawn progressively. Maybe this is over-thinking it (though the solution is simple to implement)... What do you think?

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 679283 [details] [diff] [review]
Don't use progressive drawing if not panning

Removing r? as I expect this bug has been fixed by the invalidation fixes included in bug 783368.

Comment 6

[Chris Lord [:cwiiis]]

Confirmed.

Comment 7

[Cristian Nicolae (:xti)]

I cannot reproduce this issue on the latest Nightly. Closing bug as verified fixed on:

Firefox 20.0a1 (2012-11-27)
Device: Galaxy Nexus
OS: Android 4.1.1