809198 - Enable multiple needinfo flags on a single bug

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Mark Côté [:mcote]]

The Legal team would like the ability to set needinfo flags on multiple people at once, rather than serially. This is probably generally beneficial.

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch allow multiple needinfo requests per bug (v1)

Comment 2

[:glob ✱]

Comment on attachment 679292 [details] [diff] [review]
Patch allow multiple needinfo requests per bug (v1)

Review of attachment 679292 [details] [diff] [review]:
-----------------------------------------------------------------

if you have a needinfo request directed at you, and there's another one at someone else, the wording isn't very clear:

Adding comment will automatically clear needinfo request.
[ ] I am providing the requested information for [e-mail] (will clear the needinfo request).

if there's multiple flags, the requestee should be explicitly stated for each flag:

Adding a comment will automatically clear the needinfo request for [e-mail]
[ ] I am providing the requested information for [e-mail] (will clear this needinfo request).


otherwise looks good.

::: extensions/Needinfo/Extension.pm
@@ +75,5 @@
> +    my @needinfo_overrides;
> +    foreach my $key (grep(/^needinfo_override_(\d+)$/, keys %{ $params })) {
> +        $key =~ /^needinfo_override_(\d+)$/;
> +        push(@needinfo_overrides, $1);
> +    }

no need to capture the \d+ on the foreach line.
or, you could drop the foreach:

push @needinfo_overrides,
     map { /(\d+)$/ }
     grep(/^needinfo_override_(\d+)$/, keys %$params);

::: extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
@@ +55,5 @@
> +            [% IF flag.requestee %] for <em>[% flag.requestee.login FILTER html %]</em>[% END %]
> +            (will clear the needinfo request).
> +          </label>
> +        [% END %]
> +        <br>

nit: remove trailing spaces

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to allow multiple needinfo requests per bug (v2)

If it looks good go ahead and check in so as to get into this update. If there is a glaring error then feel free to fix as well :)

Thanks
dkl

Comment 4

[:glob ✱]

Comment on attachment 681667 [details] [diff] [review]
Patch to allow multiple needinfo requests per bug (v2)

r=glob

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/Needinfo/Extension.pm
modified extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
Committed revision 8387.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Needinfo/Extension.pm
modified extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
Committed revision 8410.