809260 - Example codegen doesn't have #include for ErrorResult

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

If you use the example codegen on this webidl:

interface Simple
{
  [Throws]
  attribute boolean field;
};

...then the resulting file complains about "error: unknown type name 'ErrorResult'" unless you add 
  #include "mozilla/ErrorResult.h"
to the list of includes at the top of the header file.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Example codegen should include ErrorResult.h in the header.

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 679058 [details] [diff] [review]
Example codegen should include ErrorResult.h in the header.

Review of attachment 679058 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/289d4cc01767

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/289d4cc01767

Comment 5

[Boris Zbarsky [:bzbarsky]]

We don't actually have tests for this yet...  The test IDL doesn't check that the result compiles, sadly.  Or rather it compiles both with and without the rest of the patch.