Closed
Bug 809278
Opened 14 years ago
Closed 13 years ago
Remove duplicated styles in /toolkit/themes/*stripe/global/media/videoControls.css
Categories
(Toolkit :: Video/Audio Controls, defect)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.79 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
/toolkit/themes/*stripe/global/media/videoControls.css contains lots of duplicated styles for the buttons in the video control bar.
| Assignee | ||
Comment 1•13 years ago
|
||
I guess I forgot to attach the patch to this bug. It still applies cleanly and I tested it out and everything still looks good.
Attachment #696412 -
Flags: review?(dao)
| Assignee | ||
Comment 2•13 years ago
|
||
^-- Tested on Windows, Linux, and OS X.
Comment 3•13 years ago
|
||
Comment on attachment 696412 [details] [diff] [review]
Patch
> .timeThumb {
>- background: url(chrome://global/skin/media/scrubberThumb.png) no-repeat center;
>+ background-repeat: no-repeat;
>+ background-position: center;
>+ background-image: url(chrome://global/skin/media/scrubberThumb.png);
> min-width: 45px;
> min-height: 28px;
> -moz-box-pack: center;
> }
What's the point of this change?
| Assignee | ||
Comment 4•13 years ago
|
||
So the .timeThumb[showhours="true"] doesn't need to reset no-repeat and center, but I'm fine with undoing this part of the patch.
Comment 5•13 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #4)
> So the .timeThumb[showhours="true"] doesn't need to reset no-repeat and
> center
It doesn't need to do that either way.
| Assignee | ||
Comment 6•13 years ago
|
||
Yeah, you're right. I don't know why I didn't think of that.
Updated•13 years ago
|
Attachment #696412 -
Flags: review?(dao)
| Assignee | ||
Comment 7•13 years ago
|
||
Attachment #696412 -
Attachment is obsolete: true
Attachment #699232 -
Flags: review?(dao)
Updated•13 years ago
|
Attachment #699232 -
Flags: review?(dao) → review+
| Assignee | ||
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•