Closed Bug 809278 Opened 14 years ago Closed 13 years ago

Remove duplicated styles in /toolkit/themes/*stripe/global/media/videoControls.css

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file, 1 obsolete file)

/toolkit/themes/*stripe/global/media/videoControls.css contains lots of duplicated styles for the buttons in the video control bar.
Attached patch Patch (obsolete) — — Splinter Review
I guess I forgot to attach the patch to this bug. It still applies cleanly and I tested it out and everything still looks good.
Attachment #696412 - Flags: review?(dao)
^-- Tested on Windows, Linux, and OS X.
Blocks: 780826
Comment on attachment 696412 [details] [diff] [review] Patch > .timeThumb { >- background: url(chrome://global/skin/media/scrubberThumb.png) no-repeat center; >+ background-repeat: no-repeat; >+ background-position: center; >+ background-image: url(chrome://global/skin/media/scrubberThumb.png); > min-width: 45px; > min-height: 28px; > -moz-box-pack: center; > } What's the point of this change?
So the .timeThumb[showhours="true"] doesn't need to reset no-repeat and center, but I'm fine with undoing this part of the patch.
(In reply to Jared Wein [:jaws] from comment #4) > So the .timeThumb[showhours="true"] doesn't need to reset no-repeat and > center It doesn't need to do that either way.
Yeah, you're right. I don't know why I didn't think of that.
Attachment #696412 - Flags: review?(dao)
Attached patch Patch v1.1 — — Splinter Review
Attachment #696412 - Attachment is obsolete: true
Attachment #699232 - Flags: review?(dao)
Attachment #699232 - Flags: review?(dao) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: