809290 - document.referrer should be based on the script entry point

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

Currently it's based on the calling document. We decided in a recent spec thread to change this:

http://lists.w3.org/Archives/Public/public-script-coord/2012OctDec/0014.html

Comment 1

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f15467b587

Comment 2

[Bobby Holley (:bholley)]

Attachment: Fix nsLocation::CheckURL. v1

Comment 3

[Bobby Holley (:bholley)]

Attachment: Tests. v1

Comment 4

[Bobby Holley (:bholley)]

Attachment: Tests. v2

I just realized that invoking the callback on window.top from the inner iframe
will break when the mochtest is run within an iframe. Let's use
window.parent.parent instead.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 679239 [details] [diff] [review]
Fix nsLocation::CheckURL. v1

Review of attachment 679239 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsLocation.cpp
@@ +147,5 @@
> +      do_QueryInterface(nsJSUtils::GetDynamicScriptGlobal(cx));
> +    if (entryPoint) {
> +      nsCOMPtr<nsIDOMDocument> domDoc;
> +      entryPoint->GetDocument(getter_AddRefs(domDoc));
> +      doc = do_QueryInterface(domDoc);

QI to nsPIDOMWindow and set doc to entryPoint->GetDoc().

Comment 6

[Bobby Holley (:bholley)]

Filed a corresponding spec bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19893

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 679239 [details] [diff] [review]
Fix nsLocation::CheckURL. v1

Modulo Ms2ger's nit, r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 679242 [details] [diff] [review]
Tests. v2

r=me

Comment 9

[Bobby Holley (:bholley)]

Per my investigation in bug 797204, the only test in our testsuite that is sensitive to this distinction is bug dom/tests/mochitest/bugs/test_bug593174.html, which I've fixed in this patch.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9ec4fbe7040f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5272e198951c

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9ec4fbe7040f
https://hg.mozilla.org/mozilla-central/rev/5272e198951c