Stop using nsChangeHint_UpdateEffects in nsSVGRenderingObserver::DoUpdate overrides

RESOLVED FIXED in mozilla19

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

({perf})

Trunk
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
nsSVGEffects::UpdateEffects is meant to be called when changes to an element that is using SVG effects (e.g. CSS property changes) cause its frame to start/stop referencing (or reference different) SVG effects frames. Calling it when the referenced resources change is wasteful, so we should stop doing that.

FWIW we didn't used to do this. The use of nsChangeHint_UpdateEffects was added to nsSVGFilterProperty::DoUpdate in bug 458493, and to nsSVGMarkerProperty::DoUpdate in bug 472135.
(Assignee)

Comment 1

6 years ago
Created attachment 679040 [details] [diff] [review]
patch
Attachment #679040 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Version: 17 Branch → Trunk
https://hg.mozilla.org/mozilla-central/rev/cbafefd68d1c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.