Closed
Bug 809376
Opened 13 years ago
Closed 13 years ago
[Contacts] Facebook - After unlinking we should be in contact detail
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-basecamp:-)
VERIFIED
FIXED
| blocking-basecamp | - |
People
(Reporter: crdlc, Assigned: crdlc)
Details
(Keywords: polish)
Attachments
(1 file, 2 obsolete files)
Currently after unlinking a contact we go to contact list but we should remain the contact detail card -> Navigation error that is resolved here
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
blocking-basecamp: --- → ?
| Assignee | ||
Comment 1•13 years ago
|
||
please comments here:
https://github.com/mozilla-b2g/gaia/pull/6237
| Assignee | ||
Comment 2•13 years ago
|
||
Attachment #679092 -
Flags: review?(jmcf)
| Assignee | ||
Comment 3•13 years ago
|
||
Attachment #679092 -
Attachment is obsolete: true
Attachment #679092 -
Flags: review?(jmcf)
Attachment #679197 -
Flags: review?(jmcf)
| Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 679197 [details]
Implemented suggestions from Jose
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed:
Risk to taking this patch (and alternatives if risky):
Attachment #679197 -
Flags: approval-gaia-master?(francisco.jordano)
Updated•13 years ago
|
Attachment #679197 -
Flags: review?(jmcf) → review+
| Assignee | ||
Comment 6•13 years ago
|
||
Attachment #679581 -
Flags: review?(jmcf)
| Assignee | ||
Updated•13 years ago
|
Attachment #679197 -
Attachment is obsolete: true
Attachment #679197 -
Flags: approval-gaia-master?(francisco.jordano)
Updated•13 years ago
|
Attachment #679197 -
Flags: approval-gaia-master+
| Assignee | ||
Updated•13 years ago
|
Attachment #679581 -
Flags: approval-gaia-master?(francisco.jordano)
Comment 7•13 years ago
|
||
Comment on attachment 679581 [details]
Deleting code not needed
Per seen in the PR and the changes addressed giving the a=me
Attachment #679581 -
Flags: approval-gaia-master?(francisco.jordano) → approval-gaia-master+
Comment 8•13 years ago
|
||
Comment on attachment 679581 [details]
Deleting code not needed
https://github.com/mozilla-b2g/gaia/commit/8c2857a82bb148d7017e47367a08021b3786e843
Attachment #679581 -
Flags: review?(jmcf) → review+
Updated•13 years ago
|
Component: Gaia → Gaia::Contacts
Flags: approval-gaia-master+
| Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Retested with Unagi build
Gecko-feef5f9
Gaia-3c84fa2
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•