Closed Bug 809403 Opened 7 years ago Closed 7 years ago

Sync Gecko C++ version of the HTML parser with changes made for Rust

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: hsivonen, Assigned: hsivonen)

Details

Attachments

(2 files, 1 obsolete file)

In order to facilitate the automatic translation of the HTML parser to Rust, some cases inside switches in the tree builder need to be reordered in order to make it easier to translate a switch into a series of if statements. To make sure that the different versions don't diverge too much, the results of the change needs to be landed for Gecko as well.
Attached patch Changes made for Rust (obsolete) — Splinter Review
Looking for the rubber-stamp discussed f2f.

The changes pass the treebuilder test suite in both Java and C++. This patch removes one useless switch and makes a couple of other switches rewritable as a bunch of ifs.
Attachment #679134 - Attachment is obsolete: true
Attachment #679643 - Flags: review?(bugs)
Could you still give -w patch.
I think it might be useful in this case.
Comment on attachment 679643 [details] [diff] [review]
Changes made for Rust, v2

rs=me
Attachment #679643 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/f2e49ecb6779
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.