Closed
Bug 809403
Opened 13 years ago
Closed 13 years ago
Sync Gecko C++ version of the HTML parser with changes made for Rust
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: hsivonen, Assigned: hsivonen)
Details
Attachments
(2 files, 1 obsolete file)
|
56.45 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
45.15 KB,
patch
|
Details | Diff | Splinter Review |
In order to facilitate the automatic translation of the HTML parser to Rust, some cases inside switches in the tree builder need to be reordered in order to make it easier to translate a switch into a series of if statements. To make sure that the different versions don't diverge too much, the results of the change needs to be landed for Gecko as well.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Looking for the rubber-stamp discussed f2f.
The changes pass the treebuilder test suite in both Java and C++. This patch removes one useless switch and makes a couple of other switches rewritable as a bunch of ifs.
Attachment #679134 -
Attachment is obsolete: true
Attachment #679643 -
Flags: review?(bugs)
|
||
Comment 3•13 years ago
|
||
Could you still give -w patch.
I think it might be useful in this case.
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 679643 [details] [diff] [review]
Changes made for Rust, v2
rs=me
Attachment #679643 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•