809404 - Configuring libffi ignores CC/CXX from mozconfig and picks up the system compiler

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

+++ This bug was initially created as a clone of Bug #748138 +++

I've been investigating an issue with some of our builds and libffi. As a result, I've noticed that libffi isn't actually picking up the compiler referenced in CC/CXX in the mozconfig, but is picking up the system mozconfig.

So on our Firefox builders, in mozconfig.linux we have:

CC=/tools/gcc-4.5-0moz3/bin/gcc
CXX=/tools/gcc-4.5-0moz3/bin/g++

However, libffi configure is picking "gcc" i.e. the system one, which is actually version 4.1.1.

That doesn't seem quite right, especially as I believe 4.1.1 supports a different default debug symbol set(?).

You can see this happening if you read through the configure lines of any nightly build, e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=11120042&tree=Firefox&full=1

Comment 1

[Edmund Wong (:ewong)]

This is preventing our l10n-nightlies from building.

Comment 2

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #1)
> This is preventing our l10n-nightlies from building.

and by nightlies I mean OSX64 nightlies.

Comment 3

[Edmund Wong (:ewong)]

Attachment: export CC/CXX to set the CC and CXX env variables.

I tried this on sea-mini-osx64-4's existing .mozconfig, and it configures through.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 679123 [details] [diff] [review]
export CC/CXX to set the CC and CXX env variables.

Actually build/macosx/universal/mozconfig sources macosx/common which exports CC and CXX (with clang) as used by tooltool

The *real* fix [at least for us, short term] is to use tooltool in l10n jobs too.

Comment 5

[Justin Wood (:Callek)]

Attachment: [custom] v1

I won't be able to get at this for a day or two to test. Can you verify it succeeds a checkconfig?

Comment 6

[Edmund Wong (:ewong)]

Pushed to buildbotcustom:
http://hg.mozilla.org/build/buildbotcustom/rev/5938a63af4de

Comment 7

[Justin Wood (:Callek)]

Attachment: [custom] Part 2

This is needed to set the path right for this step, otherwise we don't find releng.manifest

Comment 8

[Edmund Wong (:ewong)]

Pushed to buildbotcustom:
http://hg.mozilla.org/build/buildbotcustom/rev/01c2c2191f84

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

This can also be an issue building firefox locally. I've been using clang on OS X, and something happened recently that made my gcc not work (this is an unrelated issue). As a result, when trying to build libffi, configure ignored mozconfig, tried to use gcc, and failed. Obviously, one answer is "fix whatever's wrong with gcc", but it would also be great if the build system always followed the compiler choices in mozconfig.

Comment 10

[Frank-Rainer Grahl (:frg)]

Let us assume it is fixed.