Closed
Bug 809425
Opened 12 years ago
Closed 12 years ago
Fix GCC 4.7 warnings in nsDocumentViewer.cpp
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: mounir, Assigned: mounir)
Details
Attachments
(1 file, 1 obsolete file)
|
3.26 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #679136 -
Flags: review?(bzbarsky)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 679136 [details] [diff] [review]
Patch
Did this compile? There's no PR_PRINTING symbol; that should presumable be NS_PRINTING?
Attachment #679136 -
Flags: review?(bzbarsky) → review-
|
Assignee | |
Comment 2•12 years ago
|
||
It was actually compiling but I was taking the other code path (NS_PRINTING not defined) so the typo was working like a charm locally. Just got some try results where it is working less nicely. Sorry about that.
Attachment #679136 -
Attachment is obsolete: true
Attachment #679158 -
Flags: review?(bzbarsky)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 679158 [details] [diff] [review]
Patch
r=me
Attachment #679158 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla19
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•