Closed Bug 809425 Opened 8 years ago Closed 8 years ago

Fix GCC 4.7 warnings in nsDocumentViewer.cpp

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
No description provided.
Attachment #679136 - Flags: review?(bzbarsky)
Comment on attachment 679136 [details] [diff] [review]
Patch

Did this compile?  There's no PR_PRINTING symbol; that should presumable be NS_PRINTING?
Attachment #679136 - Flags: review?(bzbarsky) → review-
Attached patch PatchSplinter Review
It was actually compiling but I was taking the other code path (NS_PRINTING not defined) so the typo was working like a charm locally. Just got some try results where it is working less nicely. Sorry about that.
Attachment #679136 - Attachment is obsolete: true
Attachment #679158 - Flags: review?(bzbarsky)
Comment on attachment 679158 [details] [diff] [review]
Patch

r=me
Attachment #679158 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/557e4cdad7c5
Flags: in-testsuite-
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/557e4cdad7c5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.