809438 - mozharness' clobberer.py should log "Error contacting server" as ERROR not INFO

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Ed Morley [:emorley]]

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16822207&tree=Mozilla-Inbound
{
06:30:57     INFO - #####
06:30:57     INFO - ##### Running clobber step.
06:30:57     INFO - #####
06:30:57     INFO - Running command: ['/builds/slave/b2g-m-in-panda-dep/scripts/external_tools/clobberer.py', '-s', 'scripts', '-s', 'logs', '-s', 'buildprops.json', '-t', '168', 'http://clobberer.pvt.build.mozilla.org/index.php', u'mozilla-inbound', u'b2g_mozilla-inbound_panda_dep', u'b2g-m-in-panda-dep', u'bld-linux64-ec2-048', u'http://buildbot-master35.srv.releng.scl3.mozilla.com:8001/'] in /builds/slave
06:30:57     INFO - Copy/paste: /builds/slave/b2g-m-in-panda-dep/scripts/external_tools/clobberer.py -s scripts -s logs -s buildprops.json -t 168 http://clobberer.pvt.build.mozilla.org/index.php mozilla-inbound b2g_mozilla-inbound_panda_dep b2g-m-in-panda-dep bld-linux64-ec2-048 http://buildbot-master35.srv.releng.scl3.mozilla.com:8001/
06:30:57     INFO -  Checking clobber URL: http://clobberer.pvt.build.mozilla.org/index.php?master=http%3A%2F%2Fbuildbot-master35.srv.releng.scl3.mozilla.com%3A8001%2F&slave=bld-linux64-ec2-048&builddir=b2g-m-in-panda-dep&branch=mozilla-inbound&buildername=b2g_mozilla-inbound_panda_dep
06:30:57     INFO -  Error contacting server
06:30:57    ERROR - Return code: 1
06:30:57    FATAL - failed to clobber build
06:30:57    FATAL - Exiting 2
}

Even once TBPL matches against "ERROR|FATAL", this message isn't going to be helpful.

Instead we need something like:
{
06:30:57     ERROR -  Error contacting server for clobberer information.
}
(or FATAL, don't mind)

Comment 1

[Aki Sasaki (not active)]

Attachment: create a clobberer error_list

There are several ways we can do this.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 679203 [details] [diff] [review]
create a clobberer error_list

http://hg.mozilla.org/build/mozharness/rev/7d01fcf91b1e