809538 - [b2g-bluetooth] Should reject file transferring request when there's no sdcard

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

Now we won't reject the file transferring request sent from remote device even if we don't have an sdcard on our device.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: handle no sdcard situation and refactory to make receiving file part more clear

* Reject file transferring request if we don't have an sdcard.
* Refactory for receiving file part. The main idea is that we begin parsing header only when a complete packet has been received.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 679288 [details] [diff] [review]
patch 1: v1: handle no sdcard situation and refactory to make receiving file part more clear

Review of attachment 679288 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with issues addressed.

::: dom/bluetooth/ObexBase.h
@@ +207,5 @@
> +      }
> +    }
> +  }
> +
> +  void GetBody(nsAutoPtr<uint8_t>& aRetBody)

Just pass a bare uint8_t pointer. We don't so much care about the type. Let the user deal with that.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: handle no sdcard situation and refactory to make receiving file part more clear, r=qdot

* nit fixed

Comment 4

[Eric Chou [:ericchou] [:echou]]

try:
https://tbpl.mozilla.org/?tree=Try&rev=74f7d8690318
https://tbpl.mozilla.org/?tree=Try&rev=1e7bfd722eed

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4bb2b6413a1f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4bb2b6413a1f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/44bfb31fa43e