Closed
Bug 809547
Opened 12 years ago
Closed 12 years ago
Investigate whether we need to preserve Location wrappers
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bholley, Assigned: bholley)
Details
Attachments
(1 file)
2.03 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Currently we don't, so expandos can probably disappear (I'm going to verify this). Given that we're nailing down our expando behavior for Location objects over in bug 808608, I think it's worth being deliberate and consistent here.
Assignee | ||
Comment 1•12 years ago
|
||
Ah, looks like we don't need to because the current implementation of Location getters in nsDOMClassInfo end up defining it as a value prop (but with a setter) on the window, so it's never collected. I don't know enough about the new bindings to know whether we risk regressing this at all when we move Location to the new bindings. Boris, if you think this test is unnecessary, please just r- it and resolve the bug. :-)
Attachment #679297 -
Flags: review?(bzbarsky)
Comment 2•12 years ago
|
||
Comment on attachment 679297 [details] [diff] [review] Tests. v1 New bindings for Window would make this test fail, but new bindings for Location (which I would hope come first) would make it preserve wrappers correctly anyway... I think we should land the test.
Attachment #679297 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e252b7ccec6e
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e252b7ccec6e
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•