809571 - Remove the libunwind stack walking code for ARM/Android

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[(no longer active)]

This code was first added in bug 734302, and with the stuff that Julian is working on, we will no longer need it.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch

This is a 3MB patch. Can't hg do rm more efficiently?

Comment 3

[(no longer active)]

(In reply to Benoit Girard (:BenWa) from comment #2)
> Created attachment 684479 [details] [diff] [review]
> patch
> 
> This is a 3MB patch. Can't hg do rm more efficiently?

No, since it wants the patches that it generates to be compatible with the Unix patch program...

Comment 4

[(no longer active)]

Comment on attachment 684479 [details] [diff] [review]
patch

Review of attachment 684479 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

Comment 5

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=dd0cbe6d15e1

Comment 6

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=dd8fb77458d0

Comment 7

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a9706887c6e

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5a9706887c6e