Last Comment Bug 809603 - Simplify border radius drawing
: Simplify border radius drawing
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla19
Assigned To: Jeff Muizelaar [:jrmuizel]
:
Mentors:
Depends on:
Blocks: 811472
  Show dependency treegraph
 
Reported: 2012-11-07 13:13 PST by Jeff Muizelaar [:jrmuizel]
Modified: 2012-11-14 13:36 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Something like this (3.54 KB, patch)
2012-11-07 14:26 PST, Jeff Muizelaar [:jrmuizel]
no flags Details | Diff | Review
Handle more cases and avoid stroking (5.80 KB, patch)
2012-11-12 14:08 PST, Jeff Muizelaar [:jrmuizel]
roc: review+
Details | Diff | Review

Description Jeff Muizelaar [:jrmuizel] 2012-11-07 13:13:45 PST
Currently we have a bunch of special cases. Some of these can be eliminated by not trying to stroke.
Comment 1 Jeff Muizelaar [:jrmuizel] 2012-11-07 14:26:27 PST
Created attachment 679377 [details] [diff] [review]
Something like this
Comment 2 Jeff Muizelaar [:jrmuizel] 2012-11-12 14:08:38 PST
Created attachment 680797 [details] [diff] [review]
Handle more cases and avoid stroking

This adds a RoundedRect class that we use to do the offsetting. This class can probably also be used elsewhere. With this patch we handle the gmail checkboxes in a single draw instead of in pieces like we currently do.
Comment 3 Jeff Muizelaar [:jrmuizel] 2012-11-12 17:58:24 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e05ac6ac23d
Comment 4 Ed Morley [:emorley] 2012-11-13 09:29:52 PST
https://hg.mozilla.org/mozilla-central/rev/0e05ac6ac23d

Note You need to log in before you can comment on or make changes to this bug.