The default bug view has changed. See this FAQ.

Simplify border radius drawing

RESOLVED FIXED in mozilla19

Status

()

Core
Layout
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug)

unspecified
mozilla19
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Currently we have a bunch of special cases. Some of these can be eliminated by not trying to stroke.
(Assignee)

Comment 1

4 years ago
Created attachment 679377 [details] [diff] [review]
Something like this
(Assignee)

Comment 2

4 years ago
Created attachment 680797 [details] [diff] [review]
Handle more cases and avoid stroking

This adds a RoundedRect class that we use to do the offsetting. This class can probably also be used elsewhere. With this patch we handle the gmail checkboxes in a single draw instead of in pieces like we currently do.
Attachment #679377 - Attachment is obsolete: true
Attachment #680797 - Flags: review?(roc)
Attachment #680797 - Flags: review?(roc) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e05ac6ac23d
https://hg.mozilla.org/mozilla-central/rev/0e05ac6ac23d
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Updated

4 years ago
Blocks: 811472
You need to log in before you can comment on or make changes to this bug.