809620 - [socorro-crashstats] certain date range for Firefox 19.0a1 in plot_signature throws a 500

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://crash-stats-new-dev.allizom.org/topcrasher/plot_signature/Firefox/19.0a1/2012-10-28/2012-11-04/ throws a 500.

Comment 1

[Robert Helmer [:rhelmer]]

Traceback:
File "/home/rhelmer/src/socorro-crashstats/vendor/lib/python/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in inner
  155.         return view(request, *args, **kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/utils.py" in wrapper
  32.         response = f(*args, **kw)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in plot_signature
  1349.     sigtrend = api.get(product, versions, signature, end_date, duration)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/models.py" in get
  607.         return self.fetch(url)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/models.py" in fetch
  126.             raise BadStatusCodeError('%s: on: %s' % (resp.status_code, url))

Exception Type: BadStatusCodeError at /topcrasher/plot_signature/Firefox/19.0a1/2012-10-28/2012-11-04/
Exception Value: 404: on: http://socorro1.dev.dmz.phx1.mozilla.com/bpapi/topcrash/sig/trend/history/p/Firefox/v/19.0a1/sig//end/2012-11-04/duration/168/steps/60

Comment 2

[Schalk Neethling [:espressive]]

Seems like this is a candidate for forms?

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Schalk Neethling [:espressive] from comment #2)
> Seems like this is a candidate for forms?

There are no HTTP params here, we could do more input validation but we'd still need to be able to handle 404 here.

Comment 4

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/285

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/70151ef3d14a027379a6c9c5629116da1e0d833c
bug 809620 - need to check that signature is specified, have to pass something to the model

https://github.com/mozilla/socorro-crashstats/commit/b65b1ec49d2c74e51c399459e64d233cb4785691
Merge pull request #285 from rhelmer/bug809620-handle-plot-signature-404

bug 809620 - need to check that signature is specified, have to pass som...

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

[10:14:29.068] GET http://crash-stats-new-dev.allizom.org/topcrasher/plot_signature/Firefox/19.0a1/2012-10-28/2012-11-04/ [HTTP/1.1 400 BAD REQUEST 21400ms]

signature is required