recent httpd.js changes have broken xpcshell for B2G

RESOLVED FIXED in Firefox 18

Status

Testing
General
RESOLVED FIXED
5 years ago
23 days ago

People

(Reporter: jduell, Assigned: gps)

Tracking

unspecified
mozilla19
x86_64
Linux
Points:
---

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

Details

Attachments

(1 attachment)

When I build with for desktop B2G:

  ac_add_options --enable-application=b2g

Running 'make xpcshell-tests' I see 108 xpcshell tests fail, all with 

  Error: resource://testing-common/httpd.js - EXPORTED_SYMBOLS is not an array.

With the same tree and --enable-application=browser, all tests succeed.

Perhaps some B2G boilerplate is already defining a different EXPORTED_SYMBOLS?
(Reporter)

Comment 1

5 years ago
We'll want xpcshell test coverage for B2G.
blocking-basecamp: --- → ?
(Assignee)

Comment 2

5 years ago
httpd.js is using "const EXPORTED_SYMBOLS" instead of "this.". I suspect this file missed the CPG refactor train.
(Assignee)

Comment 3

5 years ago
Created attachment 679448 [details] [diff] [review]
this qualify exported symbols from httpd.js, v1

I think this will do it. Patch is untested.
Attachment #679448 - Flags: review?(mcmanus)
(Assignee)

Updated

5 years ago
No longer blocks: 755196, 772272
Assignee: nobody → gps
Attachment #679448 - Flags: review?(mcmanus) → review?(jwalden+bmo)
(In reply to Gregory Szorc [:gps] from comment #3)
> I think this will do it. Patch is untested.

I've just imported it locally and now my tests pass again.

Comment 5

5 years ago
Comment on attachment 679448 [details] [diff] [review]
this qualify exported symbols from httpd.js, v1

Review of attachment 679448 [details] [diff] [review]:
-----------------------------------------------------------------

Did we really break every existing JSM when we made the change from having EXPORTED_SYMBOLS be a global variable, to having it be a property added to |this|?  I'm more than a bit surprised we think we can get away with doing this, breaking every extension that has a JSM, even if the fix for extensions is super-small.
Attachment #679448 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf947ebf44f
Target Milestone: --- → mozilla19
This only affects things running in b2g, which has no extensions.
https://hg.mozilla.org/mozilla-central/rev/ecf947ebf44f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-basecamp: ? → +
https://hg.mozilla.org/releases/mozilla-beta/rev/559b54336421
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Component: httpd.js → General
Product: Testing → Testing
You need to log in before you can comment on or make changes to this bug.