80974 - In <smtpEditOverlay.*>, minor code-cleanup

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[(not reading, please use [e-mail] instead)]

use a grid in smtpEditOverlay.xul

from smtpEditOverlay.xul

<!-- use a grid here when it's implemented -->

Comment 1

[Håkan Waara]

No need to use a grid there, from what I see by looking at the source.

However, the code is crufty, it contains a few non-theme safe stuff and such.

I can clean up the code some to make it kinda up to date.

Taking.

Comment 2

[Håkan Waara]

wow, it's a verbose use of <box/>es here.. That may be why someone thought that
we needed a grid.

Comment 3

[Håkan Waara]

Attachment: (Av1) <smtpEditOverlay.xul>

Comment 4

[Håkan Waara]

This patch only cleans up code, the UI doesn't change *a bit*.

Bhuvan, can you review this? If you want you can apply it and verify that the UI
is unchanged. I removed old cruft and fixed this file up to look decent.

Thanks

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This does not work when applied. You need to either keep the top <box 
orient="vertical"> as it is or change the overlaid elements to <vbox>

Also it would be nice if you could change the id of smtpusernamelabel to
smtp.username.label though I that's not required since that id ss not your deed.

But fix at least the first and r=sicking

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

oh, and use class="indent" rather then style="margin-left: 2em"

Comment 7

[Håkan Waara]

Patch is outdated and I have better stuff to do now (finally :) ).

Sending back to Seth.

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> oh, and use class="indent" rather then style="margin-left: 2em"

Fixed by
{
1.24	bienvenu%nventure.com	Dec 1 2003	 	fix 68341 add mnemonics to account
settings, patch by Stefan Borggraefe, r=neil.parkwaycc, sr=bienvenu, a=asa
}

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 36730 [details] [diff] [review]
(Av1) <smtpEditOverlay.xul>


Obsoleting, per comment 7.

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <smtpEditOverlay.*>

This patch does:
*Reformat code, a little in .js, "a lot" in .xul (no functional change)
*Rewrite code a little in .js
*Change |smtpusernamelabel| to |smtp.username.label|, per comment 5

*Also includes proposed 'Attachment #140317 [details] [diff] for Bugs 232755': 1 warning fix

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 140329 [details] [diff] [review]
(Bv1) <smtpEditOverlay.*>

r=me provided that you can get a mailnews peer to sr this and accept me as a
reviewer.

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 140329 [details] [diff] [review]
(Bv1) <smtpEditOverlay.*>


'sr?': see comment 11.

Comment 13

[Stefan Borggraefe]

Comment on attachment 140329 [details] [diff] [review]
(Bv1) <smtpEditOverlay.*>

This patch doesn't apply anymore because the fix for bug 232755 was checked in.

Comment 14

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1b) <smtpEditOverlay.*>

Bv1, with comment 13 suggestion(s):

*I hoped this patch would land before the other one...

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 141229 [details] [diff] [review]
(Bv1b) <smtpEditOverlay.*>


Keeping:
{
(Bv1) <smtpEditOverlay.*>	 patch		2004-01-31 16:04 PST   
bugmail: review+
}

Comment 16

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1c) <smtpEditOverlay.*>

Bv1b, against current trunk.

Comment 17

[Serge Gautherie (:sgautherie)]

Comment on attachment 167180 [details] [diff] [review]
(Bv1c) <smtpEditOverlay.*>

Keeping:
{
(Bv1) <smtpEditOverlay.*>	 patch		2004-01-31 16:04 PST   
bugmail: review+
}

Comment 18

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2) <smtpEditOverlay.*> [Checkin: See comment 20]

Bv1c, a little extended,
and without the .xul reformat part (which I just drop).

Comment 19

[David :Bienvenu]

Comment on attachment 341320 [details] [diff] [review]
(Bv2) <smtpEditOverlay.*>
[Checkin: See comment 20]

this has bit-rotted slightly, with the calls to selectProtocol - but if you fix that, r/sr=me.

Comment 20

[Serge Gautherie (:sgautherie)]

Comment on attachment 341320 [details] [diff] [review]
(Bv2) <smtpEditOverlay.*>
[Checkin: See comment 20]


http://hg.mozilla.org/comm-central/rev/1fa62d65ffcd
Bv2, with comment 19 suggestion(s).


NB: That's the 2nd 5 years old patch which I get reviews for in a few weeks. 2009 might be a good year ;-)