Closed Bug 80974 Opened 23 years ago Closed 15 years ago

In <smtpEditOverlay.*>, minor code-cleanup

Categories

(SeaMonkey :: MailNews: Account Configuration, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: sspitzer, Assigned: sgautherie)

Details

Attachments

(1 file, 4 obsolete files)

use a grid in smtpEditOverlay.xul

from smtpEditOverlay.xul

<!-- use a grid here when it's implemented -->
QA Contact: esther → stephend
No need to use a grid there, from what I see by looking at the source.

However, the code is crufty, it contains a few non-theme safe stuff and such.

I can clean up the code some to make it kinda up to date.

Taking.
Assignee: racham → hwaara
Summary: use a grid in smtpEditOverlay.xul → minor code-cleanup in smtpEditOverlay.xul
wow, it's a verbose use of <box/>es here.. That may be why someone thought that
we needed a grid.
Attached patch (Av1) <smtpEditOverlay.xul> (obsolete) — Splinter Review
This patch only cleans up code, the UI doesn't change *a bit*.

Bhuvan, can you review this? If you want you can apply it and verify that the UI
is unchanged. I removed old cruft and fixed this file up to look decent.

Thanks
This does not work when applied. You need to either keep the top <box 
orient="vertical"> as it is or change the overlaid elements to <vbox>

Also it would be nice if you could change the id of smtpusernamelabel to
smtp.username.label though I that's not required since that id ss not your deed.

But fix at least the first and r=sicking
oh, and use class="indent" rather then style="margin-left: 2em"
Patch is outdated and I have better stuff to do now (finally :) ).

Sending back to Seth.
Assignee: hwaara → sspitzer
(In reply to comment #6)
> oh, and use class="indent" rather then style="margin-left: 2em"

Fixed by
{
1.24	bienvenu%nventure.com	Dec 1 2003	 	fix 68341 add mnemonics to account
settings, patch by Stefan Borggraefe, r=neil.parkwaycc, sr=bienvenu, a=asa
}
OS: other → All
Hardware: PC → All
Comment on attachment 36730 [details] [diff] [review]
(Av1) <smtpEditOverlay.xul>


Obsoleting, per comment 7.
Attachment #36730 - Attachment description: fix → (Av1) <smtpEditOverlay.xul>
Attachment #36730 - Attachment is obsolete: true
Assignee: sspitzer → gautheri
Severity: minor → trivial
Summary: minor code-cleanup in smtpEditOverlay.xul → In <smtpEditOverlay.*>, minor code-cleanup
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Attached patch (Bv1) <smtpEditOverlay.*> (obsolete) — Splinter Review
This patch does:
*Reformat code, a little in .js, "a lot" in .xul (no functional change)
*Rewrite code a little in .js
*Change |smtpusernamelabel| to |smtp.username.label|, per comment 5

*Also includes proposed 'Attachment #140317 [details] [diff] for Bugs 232755': 1 warning fix
Attachment #140329 - Flags: review?(bugmail)
Comment on attachment 140329 [details] [diff] [review]
(Bv1) <smtpEditOverlay.*>

r=me provided that you can get a mailnews peer to sr this and accept me as a
reviewer.
Attachment #140329 - Flags: review?(bugmail) → review+
Comment on attachment 140329 [details] [diff] [review]
(Bv1) <smtpEditOverlay.*>


'sr?': see comment 11.
Attachment #140329 - Flags: superreview?(mscott)
Comment on attachment 140329 [details] [diff] [review]
(Bv1) <smtpEditOverlay.*>

This patch doesn't apply anymore because the fix for bug 232755 was checked in.
Attachment #140329 - Attachment is obsolete: true
Attachment #140329 - Flags: superreview?(mscott)
Attached patch (Bv1b) <smtpEditOverlay.*> (obsolete) — Splinter Review
Bv1, with comment 13 suggestion(s):

*I hoped this patch would land before the other one...
Comment on attachment 141229 [details] [diff] [review]
(Bv1b) <smtpEditOverlay.*>


Keeping:
{
(Bv1) <smtpEditOverlay.*>	 patch		2004-01-31 16:04 PST   
bugmail: review+
}
Attachment #141229 - Flags: superreview?(mscott)
Attachment #141229 - Flags: review+
Target Milestone: mozilla1.7alpha → ---
Product: Browser → Seamonkey
Attached patch (Bv1c) <smtpEditOverlay.*> (obsolete) — Splinter Review
Bv1b, against current trunk.
Attachment #141229 - Attachment is obsolete: true
Comment on attachment 167180 [details] [diff] [review]
(Bv1c) <smtpEditOverlay.*>

Keeping:
{
(Bv1) <smtpEditOverlay.*>	 patch		2004-01-31 16:04 PST   
bugmail: review+
}
Attachment #167180 - Flags: superreview?(bienvenu)
Attachment #167180 - Flags: review+
Attachment #141229 - Flags: superreview?(mscott)
Attachment #167180 - Flags: superreview?(bienvenu) → superreview+
QA Contact: stephend → search
Bv1c, a little extended,
and without the .xul reformat part (which I just drop).
Attachment #167180 - Attachment is obsolete: true
Attachment #341320 - Flags: superreview?(bienvenu)
Attachment #341320 - Flags: review?(bienvenu)
Component: MailNews: Message Display → Preferences
QA Contact: search → prefs
Component: Preferences → MailNews: Account Configuration
QA Contact: prefs → mailnews-account
Attachment #341320 - Flags: superreview?(bienvenu)
Attachment #341320 - Flags: superreview+
Attachment #341320 - Flags: review?(bienvenu)
Attachment #341320 - Flags: review+
Comment on attachment 341320 [details] [diff] [review]
(Bv2) <smtpEditOverlay.*>
[Checkin: See comment 20]

this has bit-rotted slightly, with the calls to selectProtocol - but if you fix that, r/sr=me.
Comment on attachment 341320 [details] [diff] [review]
(Bv2) <smtpEditOverlay.*>
[Checkin: See comment 20]


http://hg.mozilla.org/comm-central/rev/1fa62d65ffcd
Bv2, with comment 19 suggestion(s).


NB: That's the 2nd 5 years old patch which I get reviews for in a few weeks. 2009 might be a good year ;-)
Attachment #341320 - Attachment description: (Bv2) <smtpEditOverlay.*> → (Bv2) <smtpEditOverlay.*> [Checkin: See comment 20]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
You need to log in before you can comment on or make changes to this bug.