Closed
Bug 809751
Opened 12 years ago
Closed 12 years ago
presentational table related elements referred or having global ARIA attributes must be accessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
22.08 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
1) having global ARIA attribute: https://dvcs.w3.org/hg/pfwg/file/c9aa483b06ca/ARIA/1.0/tests/test-files/presentation-role/521.html <table role="presentation"> <tr> <td aria-hidden="true">Test me</td> </tr> </table> 2) referred by ARIA relation: https://dvcs.w3.org/hg/pfwg/file/c9aa483b06ca/ARIA/1.0/tests/test-files/presentation-role/524.html <table role="presentation"> <tr> <td aria-labelledby="foo"></td> </tr> </table> <div id="foo">test</div>
Assignee | ||
Updated•12 years ago
|
Summary: HTML table related elements of presentational table having global ARIA attributes must be accessible → presentational table related elements referred or having global ARIA attributes must be accessible
Assignee | ||
Comment 1•12 years ago
|
||
plush many other dupe failures: https://wiki.mozilla.org/Accessibility/ARIA1.0TestSuiteFailures#521
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → surkov.alexander
Comment 3•12 years ago
|
||
Comment on attachment 679653 [details] [diff] [review] patch diff --git a/accessible/src/base/nsAccessibilityService.cpp b/accessible/src/base/nsAccessibilityService.cpp --- a/accessible/src/base/nsAccessibilityService.cpp +++ b/accessible/src/base/nsAccessibilityService.cpp //////////////////////////////////////////////////////////////////////////////// +// Statics +//////////////////////////////////////////////////////////////////////////////// so what exactly is the point of these comments? they seem to be there just to get out of date as we move things around... + if (attrFlags & ATTR_GLOBAL) { + if ((attrFlags & ATTR_VALTOKEN) && + !nsAccUtils::HasDefinedARIAToken(aContent, attrAtom)) + continue; // token and not defined make the same if?
Attachment #679653 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #3) > so what exactly is the point of these comments? we have sections, keeping this method under nsAccessibilityService section doesn't seem right > they seem to be there just > to get out of date as we move things around... true > + if (attrFlags & ATTR_GLOBAL) { > + if ((attrFlags & ATTR_VALTOKEN) && > + !nsAccUtils::HasDefinedARIAToken(aContent, attrAtom)) > + continue; // token and not defined > > make the same if? ok
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f00ea0cb7b50
Flags: in-testsuite+
Comment 6•12 years ago
|
||
Comment on attachment 679653 [details] [diff] [review] patch Review of attachment 679653 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/src/base/nsAccessibilityService.cpp @@ +91,5 @@ > + if (aContent->GetPrimaryFrame()->IsFocusable()) > + return true; > + > + PRUint32 attrCount = aContent->GetAttrCount(); > + for (PRUint32 attrIdx = 0; attrIdx < attrCount; attrIdx++) { Hey guys, next time please keep in mind that we use uint32_t now. Thanks!
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f00ea0cb7b50
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to :Ms2ger from comment #6) > > + PRUint32 attrCount = aContent->GetAttrCount(); > > + for (PRUint32 attrIdx = 0; attrIdx < attrCount; attrIdx++) { > > Hey guys, next time please keep in mind that we use uint32_t now. Thanks! sorry, old habits die hard
You need to log in
before you can comment on or make changes to this bug.
Description
•