Closed Bug 809884 Opened 9 years ago Closed 9 years ago

'Spelt' is not in the US English dictionary

Categories

(Core :: Spelling checker, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: BenWa, Assigned: srinath)

Details

(Whiteboard: [mentor=ehsan])

Attachments

(1 file, 2 obsolete files)

From what I gather 'Spelt' out should be 'Spelled' outin US english, but there's also Spelt the grain:
http://en.wikipedia.org/wiki/Spelt
See <https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-US_dictionary> for how to fix this bug.
Whiteboard: [mentor=ehsan]
Hi Ehsan,

I'm interested in working on this. Can you please assign this to me?
Of course.
Assignee: nobody → irtmail-bugzilla
OS: Mac OS X → All
Hardware: x86 → All
Attached patch Fixing bug 809884 (obsolete) — Splinter Review
This looks correct, but there should also be changes to en-US.dic.  Did you perhaps forget to include that file in the diff?
Hi Ehsan,

Please check this patch. I've marked the previous patch as obsolete. This patch has the changes to en-US.dic
Attachment #682331 - Attachment is obsolete: true
Hmm,  this patch now loses the changes to upstream-hunspell.diff.  :-)  How do you produce your patches?  You should simply be able to run hg diff on the entire tree to get a full patch file...
Hi ehsan, 

I added the words following the instructions at https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-US_dictionary
Following that I created a new patch (hg qnew patchname.patch), refreshed the contents (hg qrefresh) and attached the patch over here.

I'll redo this and post a new patch.

Thanks for your patience!
Updated patch - contains both the upstream-hunspell.diff and en-US.dic
Attachment #682983 - Attachment is obsolete: true
Comment on attachment 683443 [details] [diff] [review]
Fixing bug 809884 (has the dic and hunspell diff files patched)

Review of attachment 683443 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!
Attachment #683443 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/95e3443b626f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.