'Spelt' is not in the US English dictionary

RESOLVED FIXED in mozilla20

Status

()

Core
Spelling checker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: srinath)

Tracking

Trunk
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=ehsan])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
From what I gather 'Spelt' out should be 'Spelled' outin US english, but there's also Spelt the grain:
http://en.wikipedia.org/wiki/Spelt

Comment 1

5 years ago
See <https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-US_dictionary> for how to fix this bug.
Whiteboard: [mentor=ehsan]
(Assignee)

Comment 2

5 years ago
Hi Ehsan,

I'm interested in working on this. Can you please assign this to me?

Comment 3

5 years ago
Of course.
Assignee: nobody → irtmail-bugzilla

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 4

5 years ago
Created attachment 682331 [details] [diff] [review]
Fixing bug 809884

Comment 5

5 years ago
This looks correct, but there should also be changes to en-US.dic.  Did you perhaps forget to include that file in the diff?
(Assignee)

Comment 6

5 years ago
Created attachment 682983 [details] [diff] [review]
Updating the patch for defect 809884

Hi Ehsan,

Please check this patch. I've marked the previous patch as obsolete. This patch has the changes to en-US.dic
Attachment #682331 - Attachment is obsolete: true

Comment 7

5 years ago
Hmm,  this patch now loses the changes to upstream-hunspell.diff.  :-)  How do you produce your patches?  You should simply be able to run hg diff on the entire tree to get a full patch file...
(Assignee)

Comment 8

5 years ago
Hi ehsan, 

I added the words following the instructions at https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-US_dictionary
Following that I created a new patch (hg qnew patchname.patch), refreshed the contents (hg qrefresh) and attached the patch over here.

I'll redo this and post a new patch.

Thanks for your patience!
(Assignee)

Comment 9

5 years ago
Created attachment 683443 [details] [diff] [review]
Fixing bug 809884 (has the dic and hunspell diff files patched)

Updated patch - contains both the upstream-hunspell.diff and en-US.dic
Attachment #682983 - Attachment is obsolete: true

Comment 10

5 years ago
Comment on attachment 683443 [details] [diff] [review]
Fixing bug 809884 (has the dic and hunspell diff files patched)

Review of attachment 683443 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!
Attachment #683443 - Flags: review+

Comment 11

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/95e3443b626f
https://hg.mozilla.org/mozilla-central/rev/95e3443b626f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.