809956 - An odd number of ] characters before ]]> makes the HTML parser ignore ]]> in a CDATA section

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Ilya]

Attachment: Pruf

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20121027181922

Steps to reproduce:

Show my XML source


Actual results:

Improper lighting source XML with CDATA directive


Expected results:

Correct lighting source XML with CDATA directive

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Deal with ] after already seeing ]]

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 680035 [details] [diff] [review]
Deal with ] after already seeing ]]

Again -w patch might be easier to review.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 680035 [details] [diff] [review]
Deal with ] after already seeing ]]

In any case, this needs some comments. The handling of ] is now pretty
confusing for someone not too familiar with token handler.

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Deal with ] after already seeing ]], with comment

This patch adds a comment. The comment is only on the .java side. Carrying it over to the .cpp side is *way* outside the scope of this bug. (Requires hacking the parser the translator uses; bug 559547.)

Comment 5

[Henri Sivonen (:hsivonen)]

Thanks for the r+.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a19ff77bee4

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0a19ff77bee4

Comment 7

[Henri Sivonen (:hsivonen)]

Ilya, thanks for reporting. As noted in the target milestone, the fix is expected to be in Firefox 19.

Comment 8

[Ilya]

Not at all