809977 - Allow output with progress bar

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

The progress bar goes away if you ask for any output. I really miss the progress bar when it isn't here.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Allow output with progress bar

I am anal. The extra blank line was annoying me.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 679767 [details] [diff] [review]
Allow output with progress bar

Review of attachment 679767 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/lib/progressbar.py
@@ +21,5 @@
>          assert not self.conservative_isatty()
>          assert limit < 9999
>  
>          self.prior = None
> +        self.atbol = True

|atbol| left me scratching my head for a good few seconds.  Can we change this to "atLineStart" or something equivalent?

::: js/src/tests/lib/results.py
@@ +120,5 @@
>              show = self.options.show
>              if self.options.failed_only and dev_label not in ('REGRESSIONS', 'TIMEOUTS'):
>                  show = False
> +            if show:
> +                self.pb.beginline()

Now that we have a generic |if show| path, can we nest the next three |if show and something| commands beneath this and remove |show and| from the nested branches?

Comment 3

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d9c283522eb4

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d9c283522eb4