Don't output loglines to stdout if they just consist of TEST-START and TEST-END

RESOLVED FIXED in Firefox 18

Status

Testing
Marionette
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Trunk
mozilla19
Points:
---

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We emit all the lines that a test has logged (using the log() method) after a test has run.  If the test hasn't used log(), this just results in something like:

START LOG:
INFO TEST-START: /home/jgriffin/mozilla-central/src/testing/marionette/client/marionette/tests/unit/test_simpletest_sanity.py:test_ok Thu Nov 08 2012 21:15:21 GMT+0000 (GMT)
INFO TEST-END: /home/jgriffin/mozilla-central/src/testing/marionette/client/marionette/tests/unit/test_simpletest_sanity.py:test_ok Thu Nov 08 2012 21:15:22 GMT+0000 (GMT)
END LOG:

This is noisy and not very helpful.  Let's output these things only if the test has actually logged something.
(Assignee)

Updated

5 years ago
Assignee: nobody → jgriffin
Blocks: 807123
(Assignee)

Comment 1

5 years ago
Created attachment 679813 [details] [diff] [review]
Remove noisy log messages,
Attachment #679813 - Flags: review?(ahalberstadt)
Comment on attachment 679813 [details] [diff] [review]
Remove noisy log messages,

Review of attachment 679813 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit to add a break statement
Attachment #679813 - Flags: review?(ahalberstadt) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 679826 [details] [diff] [review]
Remove noisy log messages,

Updated with review comments
(Assignee)

Updated

5 years ago
Attachment #679813 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Comment on attachment 679826 [details] [diff] [review]
Remove noisy log messages,

Carry r+ forward.
Attachment #679826 - Flags: review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbdd3dac268e
Whiteboard: [automation-needed-in-aurora]
How would someone verify that a specific test has been ran? Do we still get a line in the log which states that?

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/dbdd3dac268e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Comment 8

5 years ago
(In reply to Henrik Skupin (:whimboo) from comment #6)
> How would someone verify that a specific test has been ran? Do we still get
> a line in the log which states that?

Yes, you still see the usual Python unittest output.  In addition the TEST-START and TEST-END lines are still emitted via gecko's dump.
https://hg.mozilla.org/releases/mozilla-aurora/rev/15e19f1c53f9
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Whiteboard: [automation-needed-in-aurora]
You need to log in before you can comment on or make changes to this bug.