Closed Bug 810025 Opened 7 years ago Closed 7 years ago

Don't output loglines to stdout if they just consist of TEST-START and TEST-END

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox18 fixed, firefox19 fixed)

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file, 1 obsolete file)

We emit all the lines that a test has logged (using the log() method) after a test has run.  If the test hasn't used log(), this just results in something like:

START LOG:
INFO TEST-START: /home/jgriffin/mozilla-central/src/testing/marionette/client/marionette/tests/unit/test_simpletest_sanity.py:test_ok Thu Nov 08 2012 21:15:21 GMT+0000 (GMT)
INFO TEST-END: /home/jgriffin/mozilla-central/src/testing/marionette/client/marionette/tests/unit/test_simpletest_sanity.py:test_ok Thu Nov 08 2012 21:15:22 GMT+0000 (GMT)
END LOG:

This is noisy and not very helpful.  Let's output these things only if the test has actually logged something.
Assignee: nobody → jgriffin
Blocks: 807123
Attached patch Remove noisy log messages, (obsolete) — Splinter Review
Attachment #679813 - Flags: review?(ahalberstadt)
Comment on attachment 679813 [details] [diff] [review]
Remove noisy log messages,

Review of attachment 679813 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit to add a break statement
Attachment #679813 - Flags: review?(ahalberstadt) → review+
Updated with review comments
Attachment #679813 - Attachment is obsolete: true
Comment on attachment 679826 [details] [diff] [review]
Remove noisy log messages,

Carry r+ forward.
Attachment #679826 - Flags: review+
How would someone verify that a specific test has been ran? Do we still get a line in the log which states that?
https://hg.mozilla.org/mozilla-central/rev/dbdd3dac268e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(In reply to Henrik Skupin (:whimboo) from comment #6)
> How would someone verify that a specific test has been ran? Do we still get
> a line in the log which states that?

Yes, you still see the usual Python unittest output.  In addition the TEST-START and TEST-END lines are still emitted via gecko's dump.
You need to log in before you can comment on or make changes to this bug.