810062 - xpcshell: “-n” option of the does not enable TI.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Nicolas B. Pierron [:nbp]]

It seems that TI inference JSContext::typeInferenceEnabled does not rely on JSContext::hasRunOption or it does not act when the option the toggled.

File as a Javascript Engine bug, because the JSOPTION_TYPE_INFERENCE is correctly set.

Comment 1

[Nicolas B. Pierron [:nbp]]

I compared how the shell initialized TI.  Ti is initialized with the compartment init function (in jsinfer.cpp) which read from the JSContext* to determine if TI should be enabled or not.  In the shell this happens when the global object is created.

Unfortunately the global JSOPTION flags are toggled after creating the global object, which mean that the compartment of the global object does not get TI enabled because the context did not had TI enabled at this time.

Moving parts of the argument processing (the part which does not depend on the global object), should do it the trick.

Comment 2

[Nicolas B. Pierron [:nbp]]

Attachment: Toggle JSOPTION before the compartment creation.

Type inference need to be enabled in the JSContext which is creating the compartment when it is initialized.  The current option processing of the xpcshell toggle the option too late to enable it in the default compartment of the xpcshell.

This patch split the processing of arguments in 2 parts, one dealing with the arguments needed for the compartment initialization, and one needed for the xpcshell initialization, once we have a global object, which means after the compartment creation.

In addition, this patch add a -I option for enabling IonMonkey in the xpcshell.

Comment 3

[Brian Hackett [Laid off!]]

Comment on attachment 681832 [details] [diff] [review]
Toggle JSOPTION before the compartment creation.

Review of attachment 681832 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/shell/xpcshell.cpp
@@ +1291,2 @@
>          case 'n':
> +            // JS_ToggleOption

This comment should point to ProcessArgsForCompartment

Comment 4

[Nicolas B. Pierron [:nbp]]

https://tbpl.mozilla.org/?tree=Try&rev=8e812eaf4caf (Linux x86/x64 d/o)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a047867610ac

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a047867610ac