810103 - Make nsCSSStyleSheet::mRuleCollection into an nsRefPtr

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Andrew McCreight [:mccr8]]

In the traverse function for nsCSSStyleSheet I see this:
 NS_IMPL_CYCLE_COLLECTION_TRAVERSE_RAWPTR(mRuleCollection)
mRuleCollection has type |CSSRuleListImpl*|, and CSSRuleListImpl doesn't seem to be a cycle collected class, so I'm not sure why we need to have that traverse.

Comment 1

[Boris Zbarsky [:bzbarsky]]

At some point this will need to be cycle-collected (not least when it gets switched to WebIDL bindings, right?).

Comment 2

[Andrew McCreight [:mccr8]]

Sure. Maybe I could convert mRuleCollection to a refPtr to get rid of the weird TRAVESER_RAWPTR instead if you are worried about forgetting to add the field again later?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Sounds good to me!

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: refptrize, also remove pointless nullcheck

Comment 5

[Andrew McCreight [:mccr8]]

Linux64 try run
https://tbpl.mozilla.org/?tree=Try&rev=d74922c77919

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 680714 [details] [diff] [review]
refptrize, also remove pointless nullcheck

r=me

Comment 7

[Andrew McCreight [:mccr8]]

Thanks for the review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/77b383566a57

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77b383566a57