810112 - Reset permission when permission rationale changes

Status: RESOLVED WORKSFORME

(Core Graveyard :: DOM: Apps, defect)

Description

[Lucas Adamski [:ladamski]]

When the rationale for a permission changes, we should reset the permission bit to re-ask the user.

I don't feel this blocks basecamp, but nom'ing to get a sanity check.

Comment 1

[Lucas Adamski [:ladamski]]

To clarify, this should only happen for explicit permissions.  Yes, would require keep looking for string changes during updates.

Comment 2

[David Dahl :ddahl]

Is this still an issue?

Comment 3

[Gregor Wagner [:gwagner]]

I think that updating an app triggers the permission installation code which resets old permissions.

Comment 4

[David Dahl :ddahl]

(In reply to Gregor Wagner [:gwagner] from comment #3)
> I think that updating an app triggers the permission installation code which
> resets old permissions.

So, do we need to do anything (listen for events that affect permissions, etc) in between when an app is installed and when an app is updated? Or can we close this as INVALID?

Comment 5

[Gregor Wagner [:gwagner]]

The use-case mentioned in the Description should work and I think we can close this bug.
Jason, have you tested this scenario?

We do have a problem when we update an app when it's running but I guess that should be a another bug. Everything should work fine after we restart the app.

Comment 6

[Jason Smith [:jsmith]]

Yes. See bug 833633 that describes this behavior that exists today. Given that we are always resetting the permission right now, we can close this out as works for me. When we decide to fix bug 833633 however, we should make sure to handle the special case cited in this bug.