Closed Bug 810137 Opened 9 years ago Closed 9 years ago

remove video formats that we do not support

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
blocking-basecamp +
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file, 1 obsolete file)

videos=*.avi; *.divx; *.flv; *.m4v; *.mkv; *.mov; *.mp4; *.mpeg; *.mpg; *.ogm; *.ogv; *.ogx; *.rm; *.rmvb; *.smil; *.webm; *.wmv; *.xvid; *.3gp; *.ogg;
blocking-basecamp: --- → ?
roc,

above is the list of file extensions that device storage will return to the video application as *possible* video files.  I am sure this list isn't correct.

Can you help edit this list?
Paul, maybe you can help?
All those are certainly movies of some sort, but we currently support (i.e. can render):

*.mp4; *.mpeg; *.mpg; *.ogv; *.ogx; *.webm; *.3gp; *.ogg;

on a b2g device.

*.mkv can maybe be played (The webm container is a subset of the matroska container), but we can't guarantee the media will be playable.
Actually, I'm not sure we can render 3gp on the Otoro, someone should check.
We can.  It's the format output by the video recorder.
Attached patch patch v.1 (obsolete) — Splinter Review
first cut at improving the video list.
Assignee: nobody → doug.turner
Attachment #680138 - Flags: review?(paul)
Blocks: 809266
Attachment #680138 - Flags: review?(paul) → review+
Keywords: checkin-needed
Backed out for test failures. Looks like test_app_permissions.html needs updating.
https://hg.mozilla.org/integration/mozilla-inbound/rev/073c95d208a8

3803 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onfailure was called for type videos Error: TypeMismatchError - didn't expect true, but got it
3804 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onerror should fire a SecurityError - got TypeMismatchError, expected SecurityError
3816 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onfailure was called for type videos Error: TypeMismatchError - didn't expect true, but got it
3817 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onerror should fire a SecurityError - got TypeMismatchError, expected SecurityError
3832 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onerror should fire a SecurityError - got TypeMismatchError, expected SecurityError
ogm shoudl have been ogv in the tests.
Attached patch patch v.2Splinter Review
patch w/ corrected tests.
Attachment #680138 - Attachment is obsolete: true
Attachment #680537 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/907883fa76f1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.