810137 - remove video formats that we do not support

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

videos=*.avi; *.divx; *.flv; *.m4v; *.mkv; *.mov; *.mp4; *.mpeg; *.mpg; *.ogm; *.ogv; *.ogx; *.rm; *.rmvb; *.smil; *.webm; *.wmv; *.xvid; *.3gp; *.ogg;

Comment 1

[Doug Turner (:dougt)]

roc,

above is the list of file extensions that device storage will return to the video application as *possible* video files.  I am sure this list isn't correct.

Can you help edit this list?

Comment 2

[Mounir Lamouri (:mounir)]

Paul, maybe you can help?

Comment 3

[Paul Adenot (:padenot)]

All those are certainly movies of some sort, but we currently support (i.e. can render):

*.mp4; *.mpeg; *.mpg; *.ogv; *.ogx; *.webm; *.3gp; *.ogg;

on a b2g device.

*.mkv can maybe be played (The webm container is a subset of the matroska container), but we can't guarantee the media will be playable.

Comment 4

[Paul Adenot (:padenot)]

Actually, I'm not sure we can render 3gp on the Otoro, someone should check.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We can.  It's the format output by the video recorder.

Comment 6

[Doug Turner (:dougt)]

Attachment: patch v.1

first cut at improving the video list.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/479ac3187c81

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for test failures. Looks like test_app_permissions.html needs updating.
https://hg.mozilla.org/integration/mozilla-inbound/rev/073c95d208a8

3803 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onfailure was called for type videos Error: TypeMismatchError - didn't expect true, but got it
3804 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onerror should fire a SecurityError - got TypeMismatchError, expected SecurityError
3816 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onfailure was called for type videos Error: TypeMismatchError - didn't expect true, but got it
3817 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onerror should fire a SecurityError - got TypeMismatchError, expected SecurityError
3832 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/devicestorage/test/test_app_permissions.html | onerror should fire a SecurityError - got TypeMismatchError, expected SecurityError

Comment 9

[Doug Turner (:dougt)]

ogm shoudl have been ogv in the tests.

Comment 10

[Doug Turner (:dougt)]

Attachment: patch v.2

patch w/ corrected tests.

Comment 11

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/907883fa76f1

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/907883fa76f1

Comment 13

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd94d4d674aa