810164 - Disable bfcache for pages with active PeerConnections

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Anant Narayanan [:anant]]

There was some discussion about the bfcache and PeerConnection in bug 694808, and it was decided to disable it for pages with active connections. This should clean up associated data channels as well.

Comment 1

[Anant Narayanan [:anant]]

Attachment: Disable bfcache - v1

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 679928 [details] [diff] [review]
Disable bfcache - v1

># HG changeset patch
># Parent c0713f3e03f676db0959fa823ba5a1677e7c9a58
>
>diff --git a/content/base/src/nsDocument.cpp b/content/base/src/nsDocument.cpp
>--- a/content/base/src/nsDocument.cpp
>+++ b/content/base/src/nsDocument.cpp
>@@ -138,16 +138,17 @@
> #include "nsIDOMPageTransitionEvent.h"
> #include "nsFrameLoader.h"
> #include "nsEscape.h"
> #include "nsObjectLoadingContent.h"
> #include "nsHtml5TreeOpExecutor.h"
> #ifdef MOZ_MEDIA
> #include "nsHTMLMediaElement.h"
> #endif // MOZ_MEDIA
>+#include "IPeerConnection.h"
> 
> #include "mozAutoDocUpdate.h"
> #include "nsGlobalWindow.h"
> #include "mozilla/dom/EncodingUtils.h"
> #include "mozilla/dom/indexedDB/IndexedDatabaseManager.h"
> #include "nsDOMNavigationTiming.h"
> #include "nsEventStateManager.h"
> 
>@@ -6737,16 +6738,29 @@ nsDocument::CanSavePresentation(nsIReque
> 
>   // Check if we have running IndexedDB transactions
>   indexedDB::IndexedDatabaseManager* idbManager =
>     indexedDB::IndexedDatabaseManager::Get();
>   if (idbManager && idbManager->HasOpenTransactions(win)) {
>     return false;
>   }
> 
>+  // Check if we have active PeerConnections
>+  nsresult rv;
>+  nsCOMPtr<IPeerConnectionManager> pcManager =
>+    do_GetService(IPEERCONNECTION_MANAGER_CONTRACTID, &rv);
Just 
nsCOMPtr<IPeerConnectionManager> pcManager = 
  do_GetService(IPEERCONNECTION_MANAGER_CONTRACTID);

>+
>+  if (pcManager && win && win->IsInnerWindow()) {
No need to check win->IsInnerWindow(). Null check for win is in theory needed.
>+interface IPeerConnectionManager : nsISupports

>+{
>+  boolean hasActivePeerConnection(in unsigned long windowID);
>+};
s/windowID/innerWindowID/

Comment 3

[Anant Narayanan [:anant]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6550240a3cb7

Comment 4

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34b4e47ebf60

Backed out due to bustage on Android/B2G. Try is your friend!

Comment 5

[Anant Narayanan [:anant]]

Thanks Jim, sorry for the trouble!

https://tbpl.mozilla.org/?tree=Try&rev=6999e5f3fa20

Comment 6

[Anant Narayanan [:anant]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f19782bd70a0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f19782bd70a0