810225 - Get rid of NSInputManager, use NSTextInputContext instead

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

NSInputManager has been deprecated on 10.6 and later. Use NSTextInputContext instead.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Replace NSInputManager in PR_LOG() with NSTextInputContext

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Replace the hack for ::TSMGetActiveDocument() with NSTextInputContext

I researched the behavior of TSMGetActiveDocument() at switching active window.

Then, 10.7's it also has same bug with 10.6. And we can refresh the internal something with a call currentInputContext of NSTextInputContext.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Replace NSInputManager in IMEInputHandler::DiscardIMEComposition() with NSTextInputContext

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.4 Replace NSInputManager in IMEInputHandler::KillIMEComposition() with NSTextInputContext

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29d5168b991f
https://hg.mozilla.org/integration/mozilla-inbound/rev/b20a4c478489
https://hg.mozilla.org/integration/mozilla-inbound/rev/91069e8f9c32
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c202f6a042f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/29d5168b991f
https://hg.mozilla.org/mozilla-central/rev/b20a4c478489
https://hg.mozilla.org/mozilla-central/rev/91069e8f9c32
https://hg.mozilla.org/mozilla-central/rev/2c202f6a042f