810246 - java.lang.IllegalArgumentException: width must be > 0 at android.graphics.Bitmap.checkWidthHeight(Bitmap.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It has been hit by 2 users in 19.0a1/20121108. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8671bfc8e9a8&tochange=36e99ea02c05

Here is a crash report: bp-f9af9bba-355d-4b84-824d-df89b2121109.

java.lang.IllegalArgumentException: width must be > 0
	at android.graphics.Bitmap.checkWidthHeight(Bitmap.java:266)
	at android.graphics.Bitmap.createBitmap(Bitmap.java:531)
	at android.graphics.Bitmap.createScaledBitmap(Bitmap.java:466)
	at org.mozilla.gecko.BrowserToolbar.setFavicon(BrowserToolbar.java:689)
	at org.mozilla.gecko.BrowserApp$16.onFaviconLoaded(BrowserApp.java:600)
	at org.mozilla.gecko.Favicons$2.run(Favicons.java:173)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4745)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgumentException%3A+width+must+be+%3E+0+at+android.graphics.Bitmap.checkWidthHeight%28Bitmap.java%29

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Protect against invalid images when setting favicons in toolbar

Comment 2

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3486aec9181e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3486aec9181e