Closed Bug 810252 Opened 7 years ago Closed 7 years ago

remove pango text-shaping codepath

Categories

(Core :: Graphics: Text, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: jfkthame, Assigned: karlt)

References

Details

Attachments

(1 file)

Now that we've enabled harfbuzz for all text shaping on Linux (in bug 797398), we can remove the older code path that uses pango to shape text runs, and simplify the Linux font backend accordingly. (This is somewhat tied up with the fontconfig-based font matching code, which we'll still need to use, so it may not be an entirely simple excision.)

I don't propose doing this immediately; we should leave the old code in place for a while until bug 797398 has shipped to the release channel (it's currently in mozilla19) and we're confident in the results.
It's been several cycles since we flipped the pref; I think it's time to say goodbye to the codepath we're no longer using.
Assignee: nobody → karlt
We won't be removing the dependency on libpango as gtk+ will pull in this library anyway and we'll need to keep some pango code to get system font metrics from gtk+.
Summary: remove pango text-shaping codepath and eliminate dependency on libpango → remove pango text-shaping codepath
Attached patch patchSplinter Review
Attachment #753072 - Flags: review?(jfkthame)
Can we also drop the use of PangoLanguage (and just use our gecko language codes to label fontsets where needed), or is that not feasible at the moment?
Font selection (gfxPangoFontGroup) still uses pango_language_includes_script() which uses mPangoLanguage.  Perhaps there are some other parts of the code that can be moved from a PangoLanguage to nsIAtom, since Gecko language atoms are (sometimes or always?) now languages instead of langGroups, but that requires more thought and is independent from the shaping code.
Fair enough; let's just do this for now. Thanks!
Attachment #753072 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/03be241006e0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.